Use raw remote URL to parse GitHub repo info#224
Open
matias-christensen-skydio wants to merge 1 commit intomainfrom
Open
Use raw remote URL to parse GitHub repo info#224matias-christensen-skydio wants to merge 1 commit intomainfrom
matias-christensen-skydio wants to merge 1 commit intomainfrom
Conversation
git remote get-url applies url.*.insteadOf rewriting before returning the URL. If a user has configured insteadOf rules that rewrite the hostname (e.g. to route through a custom SSH host alias), the returned URL no longer contains "github.com" and revup fails to extract the repo owner and name. Using git config --get reads the URL exactly as stored in the repo config, before any rewriting is applied. The stored URL is what the user originally configured to point at GitHub, so it will always be parseable. The insteadOf rewriting still takes effect for all actual git operations (fetch, push, etc.) since those go through the normal git remote machinery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git remote get-urlappliesurl.*.insteadOfrewriting before returning the URL. If a user has configuredinsteadOfrules that rewrite the hostname (e.g. to route through a custom SSH host alias), the returned URL no longer contains "github.com" and revup fails to extract the repo owner and name.This changes
get_github_repo_infoto usegit config --get remote.<name>.urlinstead, which reads the URL exactly as stored in the repo config before any rewriting is applied. The stored URL is what the user originally configured to point at GitHub, so it will always be parseable. TheinsteadOfrewriting still takes effect for all actual git operations (fetch, push, etc.) since those go through the normal git remote machinery.