Skip to content

typing: Add missing annotations#584

Merged
ValerianRey merged 23 commits intomainfrom
add-missing-annotations
Feb 20, 2026
Merged

typing: Add missing annotations#584
ValerianRey merged 23 commits intomainfrom
add-missing-annotations

Conversation

@ValerianRey
Copy link
Contributor

@ValerianRey ValerianRey commented Feb 19, 2026

  • Add ANN ruff rule

  • Add noqa comment in test_lightning_integration

  • Add annotations in static_plotter and rename a variable

  • Add annotations in conftest.py

  • Add annotations in run_profiler.py

  • Add -> None to init, init_subclass, main, and to test functions

  • Add -> str to str

  • Add -> "MemoryFrame" to MemoryFrame.from_event

  • Add annotations for args and kwargs (Any)

  • Add annotations for ctx

  • Add annotations for obj

  • Add annotations for chunk_size

  • Add annotations to _make_tensors

  • Add annotations to CloneParams

  • Add annotations to InterModuleParamReuse.forward

  • Add annotations to time_call

  • Add annotations to update_gradient_coordinate

@ValerianRey ValerianRey added the cc: typing Conventional commit type for improvements to typing. label Feb 19, 2026
@ValerianRey ValerianRey self-assigned this Feb 19, 2026
@ValerianRey ValerianRey force-pushed the add-missing-annotations branch from aa7fb9f to bab8995 Compare February 19, 2026 11:18
Copy link
Contributor

@PierreQuinton PierreQuinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy to review, thx!

@ValerianRey ValerianRey merged commit c08a855 into main Feb 20, 2026
15 checks passed
@ValerianRey ValerianRey deleted the add-missing-annotations branch February 20, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cc: typing Conventional commit type for improvements to typing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments