Closed
Conversation
github-actions
bot
added
the
cc: ci
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
…is is to be reverted
…tags, this is to be reverted" This reverts commit e2338d1.
Contributor
So nice |
PierreQuinton
commented
Aug 9, 2025
Co-authored-by: Pierre Quinton <pierre.quinton@epfl.ch>
Contributor
|
Actually I prefer doing that manually, at least for now. The rules would be a bit too complex to do that really properly automatically I think. Archiving the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this does not remove tags if not needed anymore. I think this shouldn't in case we want to manually add a tag, for instance if we change documentation in the docstrings, then this could be tagged with
docseven though no change happened intorchjd/docs.In a later version, we could have all tags completely decided by the CI, For instance, the title of the PR could give the tag associated to the type of change, then we could do a diff of the built doc with the one on main to see if there are changes and tag as docs in this case etc... Some tags could remain addable such as
breaking changeorstyle.