Fix AppleScript execution for multi-line scripts#3
Open
jbkjr wants to merge 1 commit intoSiddhant-K-code:mainfrom
Open
Fix AppleScript execution for multi-line scripts#3jbkjr wants to merge 1 commit intoSiddhant-K-code:mainfrom
jbkjr wants to merge 1 commit intoSiddhant-K-code:mainfrom
Conversation
The previous implementation replaced newlines with spaces when executing AppleScript, which caused syntax errors because AppleScript requires newlines or semicolons between statements. This fix: - Splits the script into individual lines - Passes each line as a separate -e argument to osascript - Properly escapes single quotes in the script content Fixes the "syntax error: Expected end of line but found 'tell'" error that occurred when creating notes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The previous implementation in
runAppleScript()replaced all newlines with spaces:This resulted in invalid AppleScript like:
AppleScript requires newlines or semicolons between statements - spaces don't work.
Solution
-eargument toosascript(the documented way to run multi-line scripts)Test plan
create-note- now works correctlysearch-notes- works correctlyget-note-content- works correctly🤖 Generated with Claude Code