Open
Conversation
zack-freedman-shopify
force-pushed
the
zack.worldwide.update-tax-inclusivity
branch
from
cc044b6 to
23fb522
Compare
cbothner
reviewed
Mar 10, 2026
There was a problem hiding this comment.
Definitely not....
cbothner
reviewed
Mar 10, 2026
| @@ -26,6 +26,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| - Security in case of vulnerabilities. | |||
|
|
|||
| ## [Unreleased] | |||
Author
There was a problem hiding this comment.
I think we'd either need to wait until this goes out or get them to rebase on this.
Considering we're waiting on the feature flag to deploy to our own repo before this merges, I'd say let's wait.
Member
There was a problem hiding this comment.
That PR went out. Bump in this PR to avoid another one just for that?
zack-freedman-shopify
force-pushed
the
zack.worldwide.update-tax-inclusivity
branch
from
23fb522 to
2a0408a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
The following countries are tax inclusive and should be reflected as such:
...
What approach did you choose and why?
Updated the yaml files where the field lives.
...
...
...
Testing
...
Checklist