Open
Conversation
larouxn
force-pushed
the
modernize_rubocop
branch
3 times, most recently
from
e7c2b11 to
3ba22ab
Compare
- Update all rubocop gems to latest possible versions - Migrate `.rubocop.yml` to `plugins` syntax - Correct all offences auto and manual - Bump ruby-lsp gem to avoid unrecognized cop errors
larouxn
force-pushed
the
modernize_rubocop
branch
from
3ba22ab to
291801c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Modernize the RuboCop usage via gem upgrades, plugins syntax, and offence corrections.
What approach did you choose and why?
As mentioned above:
.rubocop.ymltopluginssyntaxruby-lspto latest to avoid the following cop errors popupFor the gem upgrades:
bundle update rubocop rubocop-minitest rubocop-performance rubocop-rake rubocop-shopifyWhat should reviewers focus on?
Any concerns about the offence corrections?
The impact of these changes
The codebase will be in a more maintainable state going forward.
Testing
bundle exec rakeChecklist
Determined not necessary as it's a developer facing change, not user facing.