Fix OIDC Trusted Publishing workflow#1149
Merged
graygilmore merged 1 commit intomainfrom Mar 16, 2026
Merged
Conversation
Remove broken condition on OIDC test step that referenced non-existent step ID 'version', causing the test to silently never run. Remove unnecessary NPM_TOKEN: '' override since the workflow-level NPM_TOKEN was already removed. Align changeset access config with the actual publish behavior (all packages already declare publishConfig.access: public). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
EvilGenius13
approved these changes
Mar 16, 2026
tgeselle
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ifcondition on the "Test OIDC Token" step that referenced a non-existent step ID (version), causing the OIDC sanity check to silently never runNPM_TOKEN: ''override from the changesets step env (the workflow-levelNPM_TOKENwas already removed in a prior commit)accessfromrestrictedtopublicto match actual publish behavior (all 12 publishable packages already declarepublishConfig.access: "public")Context
The recent switch to OIDC Trusted Publishing successfully publishes 9/11 packages. The 2 remaining failures (
@shopify/codemirror-language-clientand@shopify/theme-graph) are caused by missing npm-side Trusted Publishing configuration, which is being handled separately.