[rb] Patch devtools to permit up to 3 versions back#17219
Closed
[rb] Patch devtools to permit up to 3 versions back#17219
Conversation
Whilst there is an issue with devtools being released to rubygems, this is a short "quick" temporary fix to unblock users who now are on chrome v146 and cannot use selenium w/ devtools
Contributor
Review Summary by QodoExtend devtools fallback to support 3 versions back
WalkthroughsDescription• Extends devtools version fallback to support up to 3 versions back • Allows users on Chrome v146 to use Selenium with older devtools versions • Temporary workaround for devtools gem release delays File Changes1. rb/lib/selenium/devtools.rb
|
Contributor
Code Review by Qodo
1. Comment restates behavior
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Ruby DevTools loader to tolerate a wider mismatch window between the requested Chrome/DevTools version and the available selenium-devtools gem versions, temporarily unblocking users on newer Chrome releases.
Changes:
- Extend the DevTools fallback logic from “up to 2 versions back” to “up to 3 versions back”.
- Update the inline comment to reflect the new fallback window.
Comment on lines
39
to
+47
| begin | ||
| load_old_version(@version - 2) | ||
| rescue LoadError | ||
| raise WebDriver::Error::WebDriverError, | ||
| 'Could not find a valid devtools version; use a more recent version of selenium-devtools gem' | ||
| begin | ||
| load_old_version(@version - 3) | ||
| rescue LoadError | ||
| raise WebDriver::Error::WebDriverError, | ||
| 'Could not find a valid devtools version; use a more recent version of selenium-devtools gem' | ||
| end |
Comment on lines
+42
to
+46
| begin | ||
| load_old_version(@version - 3) | ||
| rescue LoadError | ||
| raise WebDriver::Error::WebDriverError, | ||
| 'Could not find a valid devtools version; use a more recent version of selenium-devtools gem' |
Contributor
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
cgoldberg
changed the title
Member
|
I just pushed devtools 144 and 145. This is not needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst there is an issue with devtools being released to rubygems, this is a short "quick" temporary fix to unblock users who now are on chrome v146 and cannot use selenium w/ devtools
🔗 Related Issues
💥 What does this PR do?
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes