Conversation
The original shader could cause a compute shader compiling error which wasn't very easy to trace. It is better to set the initial value to a very large number instead to something that isn't supported by some systems.
Fixed shakiness described in issues SebLague#13 and SebLague#18 , Unity updated to 2020.3.1f1 (77a89f25062f)
Delofon
commented
Mar 31, 2021
Comment on lines
+178
to
+180
| if (Time.timeScale == 0) { | ||
| return; | ||
| } |
Author
There was a problem hiding this comment.
This was not in original source code, and there doesn't seem to be anything that breaks up in void FixedUpdate() without it, but I placed it here anyway just for convenience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 389eb16: The original shader could cause a compute shader compiling error which wasn't very easy to trace. It is better to set the initial value to a very large number instead to something that isn't supported by some systems.
Trace of this compiling error was seen in issue #24
Commit a265caa: Originally, moving astronaut or camera around would cause shaking similar to floating-point precision issues shaking. This should hopefully fix that.