Skip to content

Support new redumper changes #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnadareski merged 3 commits into from
Feb 23, 2026
Merged

Support new redumper changes #948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64d499c
Support new redumper changes
Deterous Feb 23, 2026
6a1c37b
sbram
Deterous Feb 23, 2026
f37491d
Merge branch 'master' into bumper-redumper
Deterous Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELIST.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
- Support new redumper log for current profile
- Minor commandline program cleanup
- This might take a while...
- Support new redumper changes

### 3.6.0 (2025-11-28)

Expand Down
1 change: 1 addition & 0 deletions MPF.ExecutionContexts/Redumper/Enumerations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ public enum DriveType
MTK8C,
MTK3,
MTK2,
MTK2B,
}

/// <summary>
Expand Down
2 changes: 2 additions & 0 deletions MPF.ExecutionContexts/Redumper/ExecutionContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ public override int? Speed
//[FlagStrings.Firmware] = new StringInput(FlagStrings.Firmware) { Quotes = true },
[FlagStrings.ForceFlash] = new FlagInput(FlagStrings.ForceFlash),
[FlagStrings.SkipSubcodeDesync] = new FlagInput(FlagStrings.SkipSubcodeDesync),
[FlagStrings.Rings] = new FlagInput(FlagStrings.Rings),
[FlagStrings.CdrErrorThreshold] = new Int32Input(FlagStrings.CdrErrorThreshold),
[FlagStrings.ScsiTimeout] = new Int32Input(FlagStrings.ScsiTimeout),

Expand Down Expand Up @@ -222,6 +223,7 @@ public override Dictionary<string, List<string>> GetCommandSupport()
//FlagStrings.Firmware,
FlagStrings.ForceFlash,
FlagStrings.SkipSubcodeDesync,
FlagStrings.Rings,
FlagStrings.CdrErrorThreshold,
FlagStrings.ScsiTimeout,

Expand Down
1 change: 1 addition & 0 deletions MPF.ExecutionContexts/Redumper/FlagStrings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ public static class FlagStrings
public const string Firmware = "--firmware";
public const string ForceFlash = "--force-flash";
public const string SkipSubcodeDesync = "--skip-subcode-desync";
public const string Rings = "--rings";
public const string CdrErrorThreshold = "--cdr-error-threshold";
public const string ScsiTimeout = "--scsi-timeout";

Expand Down
6 changes: 3 additions & 3 deletions MPF.Processors.Test/RedumperTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public void GetOutputFiles_DVD_Populated()
var processor = new Redumper(RedumpSystem.IBMPCcompatible);

var actual = processor.GetOutputFiles(MediaType.DVD, outputDirectory, outputFilename);
Assert.Equal(17, actual.Count);
Assert.Equal(18, actual.Count);
}

[Fact]
Expand All @@ -125,7 +125,7 @@ public void GetOutputFiles_HDDVD_Populated()
var processor = new Redumper(RedumpSystem.IBMPCcompatible);

var actual = processor.GetOutputFiles(MediaType.HDDVD, outputDirectory, outputFilename);
Assert.Equal(12, actual.Count);
Assert.Equal(13, actual.Count);
}

[Fact]
Expand All @@ -136,7 +136,7 @@ public void GetOutputFiles_BluRay_Populated()
var processor = new Redumper(RedumpSystem.IBMPCcompatible);

var actual = processor.GetOutputFiles(MediaType.BluRay, outputDirectory, outputFilename);
Assert.Equal(12, actual.Count);
Assert.Equal(13, actual.Count);
}

[Fact]
Expand Down
2 changes: 2 additions & 0 deletions MPF.Processors/Redumper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,7 @@ internal override List<OutputFile> GetOutputFiles(MediaType? mediaType, string?
new($"{outputFilename}.1.physical", OutputFileFlags.Binary
| OutputFileFlags.Zippable,
"physical_1"),
new([$"{outputFilename}.sdram"], OutputFileFlags.Deleteable),
new($"{outputFilename}.security", System.IsXGD() && !IsManufacturerEmpty($"{basePath}.manufacturer")
? OutputFileFlags.Required | OutputFileFlags.Binary | OutputFileFlags.Zippable
: OutputFileFlags.Binary | OutputFileFlags.Zippable,
Expand Down Expand Up @@ -691,6 +692,7 @@ internal override List<OutputFile> GetOutputFiles(MediaType? mediaType, string?
new($"{outputFilename}.3.physical", OutputFileFlags.Binary
| OutputFileFlags.Zippable,
"physical_3"),
new([$"{outputFilename}.sbram"], OutputFileFlags.Deleteable),
new($"{outputFilename}.skeleton", OutputFileFlags.Binary
| OutputFileFlags.Zippable,
"skeleton"),
Expand Down