Use replicaCount Value in Deployment Template#77
Open
epichb wants to merge 1 commit intoSQLJames:mainfrom
Open
Use replicaCount Value in Deployment Template#77epichb wants to merge 1 commit intoSQLJames:mainfrom
replicaCount Value in Deployment Template#77epichb wants to merge 1 commit intoSQLJames:mainfrom
Conversation
Contributor
|
i think a more appropriate way would be to remove the value from helm values and keep it hardcoded in the deployment. |
Author
|
I see your point. My original use case was scaling down the instance when nobody was on the server, but that is probably better done by scaling manually and (in my case) excluding replica count from the Argo sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The configured
replicaCountvalue was not used in the deployment config. This PR aims to remediate this issue.