Open
Conversation
Contributor
viveknimkarde
commented
Jun 20, 2018
viveknimkarde
commented
- Add Text Emotion API wrapper for python
sushant-hiray
requested changes
Jun 21, 2018
test/test_text_recoginse_emotion.py
Outdated
| @@ -0,0 +1,52 @@ | |||
| # coding: utf-8 | |||
test/test_text_recoginse_emotion.py
Outdated
| import uuid | ||
|
|
||
|
|
||
| class TestTextEmootion(unittest.TestCase): |
test/test_text_recoginse_emotion.py
Outdated
|
|
||
| def setUp(self): | ||
| deepaffects.configuration.api_key['apikey'] = os.environ['DEEPAFFECTS_API_KEY'] | ||
| self.webhook_url = os.environ["DEEPAFFECTS_API_WEBHOOK"] |
Contributor
There was a problem hiding this comment.
use consistent quotes
test/test_text_recoginse_emotion.py
Outdated
| def tearDown(self): | ||
| pass | ||
|
|
||
| def test_async_diarize_audio(self): |
Contributor
There was a problem hiding this comment.
you aren't testing diarize audio here.
Contributor
There was a problem hiding this comment.
Add more tests to test the cases where the request is malformed. Also check for all the expected keys in output
viveknimkarde
force-pushed
the
add-text-emotion-api
branch
2 times, most recently
from
217cd50 to
8890efd
Compare
viveknimkarde
force-pushed
the
add-text-emotion-api
branch
from
8890efd to
f6076e3
Compare
toyokazu03102478
approved these changes
Jan 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.