Feature/adding blip to caf #155

Jjm321814 · 2025-11-10T15:08:52Z

This is part of a large array of PR to add blip objects to CAF files.
Previously the key blip structs were defined in sbndcode and this PR simply moves them to sbnobj.

Jjm321814 · 2025-11-10T15:11:02Z

An associated branch in sbndcode (also feature/AddingBlipToCAF) has the updated libraries linking necessary to point here. Once this one is in a release we can delete the file copies in sbndcode

kjplows · 2025-11-12T19:08:27Z

Hi @Jjm321814 , is there a required PR in sbndcode to accompany this? If yes, please point me to that PR. Thanks!

kjplows · 2025-11-12T19:10:46Z

Also summoning @PetrilloAtWork to take a look if there's time, not sure if ICARUS has something similar to this?

Jjm321814 · 2025-11-13T15:14:41Z

The related sbndcode changes are in SBNSoftware/sbndcode#871 but they depend on this PR, not the other way around.
This one just moves some struct definitions out of sbndcode and into sbnobj so that it can be imported into sbncode for CAFMaker.

Jjm321814 · 2025-11-13T15:23:43Z

Adding a comment to each of these to track all 4 related PR.
sbncode: SBNSoftware/sbncode#603
sbndcode: SBNSoftware/sbndcode#871
sbnobj: #155
sbnanaobj: SBNSoftware/sbnanaobj#173

The changes to sbnobj, and sbnanaobj are fully independent of any other changes, so they can be approved first.

sbndcode changes rely on sbnobj, so it will have to wait for the first approval. A later simple PR will delete the (now duplicated) class files in the BlipUtils folder here

sbncode changes rely on both sbnobj and sbnanaobj, so that will have to wait for both of the first two approvals.

Jjm321814 · 2025-11-14T19:38:56Z

Accidentally ran with the wrong blip tag and still produced a CAF file in sbndcode area, so I expect it will work with ICARUS but I can not test it.

Jjm321814 · 2025-11-29T20:24:43Z

All the suggestions here have been committed. Every struct has doxygen comments, TVector3 has been generally replaced, and the few housekeeping comments have been accepted.
A later fix can remove TVector3 from blip processing steps too. May I ask what is the issue with TVector3?

kjplows · 2025-12-14T08:17:04Z

Hi @PetrilloAtWork , it looks like Jacob has implemented all the changes requested. How does the PR look now? Thanks!

Jjm321814 · 2026-01-14T22:36:17Z

I am happy with how the CAF look coming out of the 4 PR now.

kjplows · 2026-01-15T21:00:55Z

Calling reviewers to check if these PRs are OK, @PetrilloAtWork , @henrylay97 , @sungbinoh

sungbinoh

Everything looks good. Thank you very much!

henrylay97 · 2026-01-16T09:27:45Z

sbnobj/SBND/Blip/BlipDataTypes.h

+    float   EndHitTime      = -999; ///< Depreciated
+    float   StartTime       = -999; ///< Minimum -1 sigma time of a hit in this cluster [us]
+    float   EndTime         = -999; ///< Max +1 sigma time of a hit in this cluster [us]
+    float   Timespan        = -999; ///< Hit cluster EndTime - StartTime [us]


Similar argument to SBNSoftware/sbnanaobj#173 (comment)

kjplows · 2026-01-21T16:37:46Z

Hi @PetrilloAtWork , do the changes look good to you? Thanks!

PetrilloAtWork

Many, many thanks for adding the documentation!
I have added some suggested changes to its format here and there.
Now that I know isPrimary is a flag, I think the type of that variable should be bool rather than int.
But most important: the new classes still do not show a checksum in classes_def.xml. Either you have forgotten rebuilding and recommitting the changes to it, or the dictionary is not being generated at all (which would be surprising).

PetrilloAtWork · 2026-02-09T22:58:30Z

sbnobj/SBND/Blip/classes_def.xml

+<class name="art::Wrapper<std::vector<blip::Blip> >"/>
+<class name="blip::Blip"/>
+<class name="std::vector<blip::Blip>"/>
+<class name="blip::HitClust"/>
+<class name="vector<blip::HitClust>"/>
+<class name="art::Wrapper<std::vector<blip::HitClust> >"/>
+<class name="blip::TrueBlip"/>
+<class name="std::map<int,TVector3>"/>
+<class name="art::Assns<blip::Blip,recob::Hit,void>"/>
+<class name="art::Assns<recob::Hit, blip::Blip,void>"/>
+<class name="art::Assns<blip::Blip,recob::SpacePoint,void>"/>
+<class name="art::Wrapper<art::Assns<blip::Blip,recob::Hit,void> >"/>
+<class name="art::Wrapper<art::Assns<recob::Hit,blip::Blip,void> >"/>
+<class name="art::Wrapper<art::Assns<blip::Blip,recob::SpacePoint,void> >"/>


Something is still amiss... have you rebuilt and then recommitted sbnobj/SBND/Blip/classes_def.xml? These items should show a checksum.

PetrilloAtWork · 2026-02-09T23:01:56Z

sbnobj/SBND/Blip/BlipDataTypes.h

+    float amp           = -9; ///< Amplitude of hit [ADC]
+    float rms           = -9; ///< RMS of hit shape [ticks]
+    int   trkid         = -9; ///< track ID from hit-track association object
+    int   shwrid        = -9; ///< Depreciated


Suggested change

int shwrid = -9; ///< Depreciated

int shwrid = -9; ///< Deprecated

It's about praying (depreco, I pray it to go away), not price (depretio, I lower the cost).

PetrilloAtWork · 2026-02-09T23:02:44Z

sbnobj/SBND/Blip/BlipDataTypes.h

+ * Most attributes are grabbed directly from the recob::hit, but some, like charge, involve extra processing.
+ */
+  struct HitInfo {
+    int   hitid         = -9; ///< Index of hit in recob::hit vector


Following the correct capitalisation enables Doxygen to create cross-references:

Suggested change

int hitid = -9; ///< Index of hit in recob::hit vector

int hitid = -9; ///< Index of hit in recob::Hit vector

PetrilloAtWork · 2026-02-09T23:03:39Z

sbnobj/SBND/Blip/BlipDataTypes.h

+    int   tpc           = -9; ///< TPC containing hit. From geo::WireID
+    int   plane         = -9; ///< Plane containing hit. From geo::WireID
+    int   wire          = -9; ///< Wire containing hit. From geo::WireID
+    int   chan          = -9; ///< Channel ID containing hit. From recob::Hit->Channel()


This should enable Doxygen to make a cross-reference:

Suggested change

int chan = -9; ///< Channel ID containing hit. From recob::Hit->Channel()

int chan = -9; ///< Channel ID containing hit. From recob::Hit::Channel()

PetrilloAtWork · 2026-02-09T23:03:56Z

sbnobj/SBND/Blip/BlipDataTypes.h

+    int   clustid       = -9; ///< If this hit gets gathered into a cluster, what is the index of that cluster. All hits should be in a track or a cluster
+    int   blipid        = -9; ///< If this hit gets gathered into a blip, what is the index of that blip.
+    bool  ismatch       = false; ///< Depreciated
+    float integralADC    = -999;  ///< Integral area from the recob::hit [ADCs-ticks]


Suggested change

float integralADC = -999; ///< Integral area from the recob::hit [ADCs-ticks]

float integralADC = -999; ///< Integral area from the recob::Hit [ADCs-ticks]

PetrilloAtWork · 2026-02-09T23:42:20Z

sbnobj/SBND/Blip/BlipDataTypes.h

+    std::set<int>     HitIDs; ///< Index of the recob::hit objects making up this cluster
+    std::set<int>     Wires; ///<  Set of geo::wireIDs contributing hits to this cluster


Suggested change

std::set<int> HitIDs; ///< Index of the recob::hit objects making up this cluster

std::set<int> Wires; ///< Set of geo::wireIDs contributing hits to this cluster

std::set<int> HitIDs; ///< Index of the recob::Hit objects making up this cluster

std::set<int> Wires; ///< Set of geo::WireID contributing hits to this cluster

PetrilloAtWork · 2026-02-09T23:42:56Z

sbnobj/SBND/Blip/BlipDataTypes.h

+    std::set<int>     Wires; ///<  Set of geo::wireIDs contributing hits to this cluster
+    std::set<int>     Chans; ///<  Set of raw::ChannelID_t contributing hits to this cluster
+    std::set<int>     G4IDs; ///<  simb::MCParticle track ID contributing hits to this cluster
+    std::map<int,geo::Point_t> IntersectLocations; ///< Internal reconstruction variable for recording where hit-clusters on different planes would overlap //used to be TVector3


Same comment as above:

Suggested change

std::map<int,geo::Point_t> IntersectLocations; ///< Internal reconstruction variable for recording where hit-clusters on different planes would overlap //used to be TVector3

std::map<int,geo::Point_t> IntersectLocations; ///< Internal reconstruction variable for recording where hit-clusters on different planes would overlap

PetrilloAtWork · 2026-02-10T00:42:24Z

sbnobj/SBND/Blip/BlipDataTypes.h

+    float     TimeTick        = -999;       ///< Average time of hitclusters making up blips. [tpc tick]
+    /*!
+      Hit cluster time is the charge-weighted average of the hit-peak times for hits in the cluster 
+    */
+    float     Time            = -999;       ///< Average time of hitclusters making up blips. [us] 
+    /*!
+      Hit cluster time is the charge-weighted average of the hit-peak times for hits in the cluster 
+    */


More Doxygen-y:

Suggested change

float TimeTick = -999; ///< Average time of hitclusters making up blips. [tpc tick]

/*!

Hit cluster time is the charge-weighted average of the hit-peak times for hits in the cluster

*/

float Time = -999; ///< Average time of hitclusters making up blips. [us]

/*!

Hit cluster time is the charge-weighted average of the hit-peak times for hits in the cluster

*/

/**

* @brief Average time of hitclusters making up blips. [tpc tick]

*

* Hit cluster time is the charge-weighted average of the hit-peak times for hits in the cluster.

*/

float TimeTick = -999;

/**

* @brief Average time of hitclusters making up blips. [us]

*

* Hit cluster time is the charge-weighted average of the hit-peak times for hits in the cluster.

*/

float Time = -999;

PetrilloAtWork · 2026-02-10T00:43:37Z

sbnobj/SBND/Blip/BlipDataTypes.h

+    float     ProxTrkDist     = -9;         ///< 3-D distance to closest track, assuming the blip was concident with event trigger [cm]
+    /*!
+      for properly flash matched out-of-time tracks this distance will be wrong! The blips have no such flash matching ability as of yet
+    */


Suggested change

float ProxTrkDist = -9; ///< 3-D distance to closest track, assuming the blip was concident with event trigger [cm]

/*!

for properly flash matched out-of-time tracks this distance will be wrong! The blips have no such flash matching ability as of yet

*/

/**

* @brief 3-D distance to closest track, assuming the blip was coincident with event trigger [cm]

*

* For properly flash matched out-of-time tracks this distance will be wrong!

* The blips have no such flash matching ability as of yet.

*/

float ProxTrkDist = -9;

PetrilloAtWork · 2026-02-10T00:45:10Z

sbnobj/SBND/Blip/BlipDataTypes.h

+    /*!
+      please note the blip X position is unreliable, so these distance and 3-d position derived variables may be incorrect
+    */
+    geo::Point_t  Position;                 ///< 3D position vector. Reconstructed with wrong t0! [cm]


Suggested change

/*!

please note the blip X position is unreliable, so these distance and 3-d position derived variables may be incorrect

*/

geo::Point_t Position; ///< 3D position vector. Reconstructed with wrong t0! [cm]

/**

* @brief 3D position vector. Reconstructed with wrong t0! [cm]

*

* Please note the blip X position is unreliable,

* so these distance and 3-d position derived variables may be incorrect.

*/

geo::Point_t Position;

Jjm321814 · 2026-02-10T17:32:46Z

Thanks, all the doxygen comments were accepted and implemented now.

Jjm321814 · 2026-02-10T17:41:31Z

The checksum may be from pushing from my computer rather than a gpvm. Let me try to fix it

Jjm321814 · 2026-02-10T18:55:49Z

Not sure whats going on with the checksums. Blip class and TrueBlip both get a checksum though. Otherwise all the outputs look good

Jjm321814 and others added 10 commits November 6, 2025 09:44

Adding blip data types to sbnobj to help with CAF addition

7f7a897

Moving blip utils over

18d8269

Moving blip utils

9751aa3

trying to remove depends

1387b2a

trying to remove depends

f5c315a

Im not sure how to link the dictionaries here anymore

2ce06f9

Simplifying includes

2d37c3f

trying to make a library

55d9f70

Still trying to make a library

343d755

sorting compiles

99a3c01

Jjm321814 self-assigned this Nov 10, 2025

Jjm321814 requested a review from sungbinoh November 10, 2025 15:09

compiled version

bcbb2aa

kjplows requested a review from PetrilloAtWork November 12, 2025 19:09

Jjm321814 mentioned this pull request Nov 13, 2025

Feature/adding blip to caf SBNSoftware/sbndcode#871

Open

This was referenced Nov 13, 2025

Feature/adding blip to caf SBNSoftware/sbncode#603

Open

Feature/adding blip to caf SBNSoftware/sbnanaobj#173

Open

Jacob McLaughlin and others added 2 commits November 13, 2025 18:47

small fix for sbndcode

5bfaf2c

Merge branch 'develop' into feature/AddingBlipToCAF

90a5dc2

Jjm321814 requested a review from JosiePaton November 14, 2025 19:49

linyan-w added this to SBND 2025 Fall Production Nov 17, 2025

linyan-w moved this to Waiting on Reviewer in SBND 2025 Fall Production Nov 17, 2025

nathanielerowe removed this from SBND 2025 Fall Production Nov 17, 2025

kjplows added this to SBN software development Nov 18, 2025

removed unused headers

4c9288e

Jjm321814 and others added 2 commits November 30, 2025 16:32

Fixed a comment

d460853

Merge branch 'develop' into feature/AddingBlipToCAF

bdd98cb

kjplows moved this from Open pull requests to Partially reviewed in SBN software development Dec 14, 2025

Jjm321814 and others added 9 commits January 5, 2026 11:23

made pinfo position have a capital like all other blip positions

c16b5be

Trying to fix runtime error

f4872e1

Trying to fix runtime error

e718325

Trying to fix runtime error

6930443

Trying to fix runtime error

5b3feee

Merge branch 'develop' into feature/AddingBlipToCAF

db31ab5

removing the thing I added

55f7c5d

fixing run time error

f7b4b84

The geometry wasn't needed. Geo vectors was

9524c9e

sungbinoh approved these changes Jan 15, 2026

View reviewed changes

henrylay97 approved these changes Jan 16, 2026

View reviewed changes

kjplows moved this from Partially reviewed to Testing in SBN software development Jan 21, 2026

kjplows moved this from Testing to Partially reviewed in SBN software development Jan 21, 2026

Jjm321814 mentioned this pull request Feb 9, 2026

Feature/adding blip to caf #166

Open

PetrilloAtWork requested changes Feb 10, 2026

View reviewed changes

Jjm321814 added 2 commits February 10, 2026 11:19

Merge branch 'develop' into feature/AddingBlipToCAF

8cd0ca7

addressing doxygen comments

b63c719

copy paste error

0f56d1c

	int shwrid = -9; ///< Depreciated
	int shwrid = -9; ///< Deprecated

	int hitid = -9; ///< Index of hit in recob::hit vector
	int hitid = -9; ///< Index of hit in recob::Hit vector

	int chan = -9; ///< Channel ID containing hit. From recob::Hit->Channel()
	int chan = -9; ///< Channel ID containing hit. From recob::Hit::Channel()

	float integralADC = -999; ///< Integral area from the recob::hit [ADCs-ticks]
	float integralADC = -999; ///< Integral area from the recob::Hit [ADCs-ticks]

		std::set<int> HitIDs; ///< Index of the recob::hit objects making up this cluster
		std::set<int> Wires; ///< Set of geo::wireIDs contributing hits to this cluster

	std::map<int,geo::Point_t> IntersectLocations; ///< Internal reconstruction variable for recording where hit-clusters on different planes would overlap //used to be TVector3
	std::map<int,geo::Point_t> IntersectLocations; ///< Internal reconstruction variable for recording where hit-clusters on different planes would overlap

Feature/adding blip to caf #155

Are you sure you want to change the base?

Feature/adding blip to caf #155

Conversation

Jjm321814 commented Nov 10, 2025

Uh oh!

Jjm321814 commented Nov 10, 2025

Uh oh!

kjplows commented Nov 12, 2025

Uh oh!

kjplows commented Nov 12, 2025

Uh oh!

Jjm321814 commented Nov 13, 2025

Uh oh!

Jjm321814 commented Nov 13, 2025

Uh oh!

Jjm321814 commented Nov 14, 2025

Uh oh!

Jjm321814 commented Nov 29, 2025

Uh oh!

kjplows commented Dec 14, 2025

Uh oh!

Jjm321814 commented Jan 14, 2026

Uh oh!

kjplows commented Jan 15, 2026

Uh oh!

sungbinoh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kjplows commented Jan 21, 2026

Uh oh!

PetrilloAtWork left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jjm321814 commented Feb 10, 2026

Uh oh!

Jjm321814 commented Feb 10, 2026

Uh oh!

Jjm321814 commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants