Skip to content

cmov: move tests for impls on core types to lib.rs #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tarcieri wants to merge 1 commit into from
Closed

cmov: move tests for impls on core types to lib.rs #1434

tarcieri wants to merge 1 commit into from

Conversation

@tarcieri
Copy link
Member

@tarcieri tarcieri commented Jan 26, 2026

No description provided.

@newpavlov
Copy link
Member

newpavlov commented Jan 26, 2026 •
edited
Loading

But why? I generally prefer to keep public API tests in the tests/ folder and use mod tests only for testing private APIs. IMO this PR make lib.rs unnecessarily big and cluttered.

@tarcieri
Copy link
Member Author

tarcieri commented Jan 26, 2026

I was getting annoyed by constantly switching files, but if you insist

@tarcieri tarcieri closed this Jan 26, 2026
@tarcieri tarcieri deleted the cmov/more-core-impls-tests-to-lib branch January 26, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tarcieri @newpavlov