Fixed issue #4, My fork now uses CommonJS for everything#5
Open
CodeBoy124 wants to merge 3 commits intoRubyLouvre:masterfrom
Open
Fixed issue #4, My fork now uses CommonJS for everything#5CodeBoy124 wants to merge 3 commits intoRubyLouvre:masterfrom
CodeBoy124 wants to merge 3 commits intoRubyLouvre:masterfrom
Conversation
… ES Module syntax is harder to import in CommonJS
This commit adds node_modules/ to the ignore list to prevent it from being committed to the repository. This is a common practice as node_modules/ can be easily regenerated by running `npm install` or `yarn install`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed issue #4 by changing the last line of the index.js file to use 'module.exports' instead of 'export default'.
I also explicitly set the type property in the package.json to 'commonjs' just in case.
This will make the package work for all NodeJS versions and without errors