Open
Conversation
wesrich
requested changes
Mar 2, 2026
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number }} | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number }}-${{ github.event.ref }} |
Contributor
There was a problem hiding this comment.
- This is actually bad... If you make this change, in my experience, it never catches things as concurrency issues and cancels them, as each build is a new event ref.
- I would also add that on my repos, I like
mainto always build (not cancel later pushes). If so, thecancel-in-progresssuggestion below allows it to only cancel from later pushes on the same PR.
Suggested change
| group: ${{ github.workflow }}-${{ github.event.pull_request.number }}-${{ github.event.ref }} | |
| group: ${{ github.workflow }}-${{ github.event.pull_request.number }} | |
| cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }} |
| - name: Run shared flow | ||
| uses: RoleModel/actions/linting-and-non-system-tests@v2 | ||
| - run: bin/bundler-audit | ||
| - run: bin/brakeman --quiet --no-pager --exit-on-warn --exit-on-error |
Contributor
There was a problem hiding this comment.
Not sure this will work for every repo? I guess people can remove it if they don't have brakeman installed...?
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup vips |
Contributor
There was a problem hiding this comment.
Do we ever (often?) need vips? Should we leave this in but commented out, for those who need it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The CI template was quite out of date at this point.
What Changed
What changed in this PR?
Pre-merge checklist
bin/bump_versionorbin/bump_version --patch