-
Notifications
You must be signed in to change notification settings - Fork 0
Add Dependabot Config #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| PATH | ||
| remote: . | ||
| specs: | ||
| rolemodel_rails (0.26.0) | ||
| rolemodel_rails (0.27.0) | ||
| rails (> 7.1) | ||
|
|
||
| GEM | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| PATH | ||
| remote: .. | ||
| specs: | ||
| rolemodel_rails (0.26.0) | ||
| rolemodel_rails (0.27.0) | ||
| rails (> 7.1) | ||
|
|
||
| GEM | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # This file is used by Dependabot (and more broadly GitHub) to determine who needs to review | ||
| # pull requests which contain changes to specific files. Specifically, the setup below allows | ||
| # for the dependabot PRs to automatically assign (and notify) the Craftsman and Support Dev. | ||
|
|
||
| # Dependabot / Dependency reviewers: | ||
| # TODO: Update and uncomment the following lines. | ||
| # yarn.lock @craftsman @supportdev | ||
| # Gemfile.lock @craftsman @supportdev |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| version: 2 | ||
| registries: | ||
| ruby-github: | ||
| type: rubygems-server | ||
| url: https://rubygems.pkg.github.com/RoleModel | ||
| token: ${{ secrets.ROLEMODEL_PACKAGE_REPO_READ_TOKEN }} | ||
|
|
||
| updates: | ||
| - package-ecosystem: bundler | ||
| insecure-external-code-execution: allow | ||
| registries: | ||
| - ruby-github | ||
| directory: / | ||
| schedule: | ||
| interval: weekly | ||
| day: monday | ||
| # Ignore specific dependencies or update types which may cause issues. For example: | ||
| # ignore: | ||
| # - dependency-name: 'some-gem' | ||
| # - update-types: ['version-update:semver-major'] | ||
| groups: | ||
| production-security: | ||
| dependency-type: production | ||
| applies-to: security-updates | ||
| production-major-updates: | ||
| dependency-type: production | ||
| applies-to: version-updates | ||
| update-types: | ||
| - major | ||
| production-minor-updates: | ||
| dependency-type: production | ||
| applies-to: version-updates | ||
| update-types: | ||
| - minor | ||
| - patch | ||
| development-security: | ||
| dependency-type: development | ||
| applies-to: security-updates | ||
| development-major-updates: | ||
| dependency-type: development | ||
| applies-to: version-updates | ||
| update-types: | ||
| - major | ||
| development-minor-updates: | ||
| dependency-type: development | ||
| applies-to: version-updates | ||
| update-types: | ||
| - minor | ||
| - patch | ||
| - package-ecosystem: npm | ||
| directory: / | ||
| schedule: | ||
| interval: weekly | ||
| day: monday | ||
| # Ignore specific dependencies or update types which may cause issues. For example: | ||
| # ignore: | ||
| # - dependency-name: 'some-package' | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if our private dependencies are ignored by default, does that remove the need for the scary "allow bad stuff" config above to be removed? |
||
| # - update-types: ['version-update:semver-major'] | ||
| groups: | ||
| production-security: | ||
| dependency-type: production | ||
| applies-to: security-updates | ||
| production-major-updates: | ||
| dependency-type: production | ||
| applies-to: version-updates | ||
| update-types: | ||
| - major | ||
| production-minor-updates: | ||
| dependency-type: production | ||
| applies-to: version-updates | ||
| update-types: | ||
| - minor | ||
| - patch | ||
| development-security: | ||
| dependency-type: development | ||
| applies-to: security-updates | ||
| development-major-updates: | ||
| dependency-type: development | ||
| applies-to: version-updates | ||
| update-types: | ||
| - major | ||
| development-minor-updates: | ||
| dependency-type: development | ||
| applies-to: version-updates | ||
| update-types: | ||
| - minor | ||
| - patch | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../../../.github/instructions | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a symlink for the folder. See screenshot for proof that it works in the generator.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nope, don't believe you. |
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think there was an open PR for this. I assume we're pulling from there for this? |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| ## Why? | ||
|
|
||
| Why were the changes needed? What issues were the changes addressing? | ||
| (Note: some changes may seem unrelated to the ticket, this is a great place to explain further.) | ||
|
|
||
| ## What Changed | ||
|
|
||
| What changed in this PR? | ||
|
|
||
| * [ ] Change 1 | ||
|
|
||
| ## Pre-merge checklist | ||
|
|
||
| * [ ] Update relevant READMEs | ||
|
|
||
| ## Screenshots | ||
|
|
||
| If any UI changes need to be shown off, please add screenshots here. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| module RolemodelRails | ||
| VERSION = '0.26.0' | ||
| VERSION = '0.27.0' | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allowing insecure external code execution in Dependabot configuration poses a security risk. This setting permits execution of arbitrary code during dependency updates, which could be exploited if a malicious dependency is introduced. Consider removing this line unless there's a specific, documented requirement for it, and if needed, add a comment explaining why it's necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required because of
health-checkand possibly this gem (rolemodel_rails).As a counter suggestion:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this for now, but I'd like you to explain this to me in detail sometime.
Maybe then we can put our heads together and see if something useful is knocked loose..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point it might be good to consider if our Health Check approach is worth just having almanac pull everything it needs for SHM.