Skip to content

Externals #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xtuc wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Externals #37

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a79c28
style: autofix lint
xtuc Dec 26, 2017
ab4bfc5
feat: show stack trace in error
xtuc Dec 26, 2017
6ec6519
feat: externals wip
xtuc Dec 26, 2017
accd490
Merge branch 'master' into feat-rollup-externals
xtuc Dec 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions server/child-processes/create-bundle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,18 @@ function bundle ( cwd, deep, query ) {

const code = sander.readFileSync( entry, { encoding: 'utf-8' });

let external = [];

if (typeof query.externals === 'string') {
external = query.externals.split(',');
}

if ( isModule( code ) ) {
info( `[${pkg.name}] ES2015 module found, using Rollup` );
return bundleWithRollup( cwd, pkg, entry, moduleName );
return bundleWithRollup( cwd, pkg, entry, moduleName, external );
} else {
info( `[${pkg.name}] No ES2015 module found, using Browserify` );
return bundleWithBrowserify( pkg, entry, moduleName );
return bundleWithBrowserify( pkg, entry, moduleName, external );
}
}

Expand All @@ -149,12 +155,13 @@ function findEntry ( file ) {
}
}

async function bundleWithRollup ( cwd, pkg, moduleEntry, moduleName ) {
async function bundleWithRollup ( cwd, pkg, moduleEntry, moduleName, external ) {
const bundle = await rollup.rollup({
entry: path.resolve( cwd, moduleEntry ),
plugins: [
resolve({ module: true, jsnext: true, main: false, modulesOnly: true })
]
],
external,
});

info( `[${pkg.name}] bundled using Rollup` );
Expand All @@ -181,9 +188,10 @@ async function bundleWithRollup ( cwd, pkg, moduleEntry, moduleName ) {
}
}

function bundleWithBrowserify ( pkg, main, moduleName ) {
function bundleWithBrowserify ( pkg, main, moduleName, external ) {
const b = browserify( main, {
standalone: moduleName
standalone: moduleName,
external
});

return new Promise( ( fulfil, reject ) => {
Expand Down