Add support for table creation and deletion #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbrgr
changed the title
gbrgr
commented
Feb 3, 2026
| schema_json = schema_to_json(schema) | ||
|
|
||
| # Serialize partition spec to JSON (empty string if none) | ||
| partition_spec_json = partition_spec === nothing ? "{}" : partition_spec_to_json(partition_spec) |
Contributor
Author
There was a problem hiding this comment.
Note: we use json here as the internal Rust types to expose schema information are overly complex, and we'd have to add a lot of types. We can consider in the future whether we want that, but for now having a simple JSON interface here seems reasonable given that we don't care about the serialization/deserialization overhead here.
gbrgr
commented
Feb 3, 2026
| @@ -0,0 +1,1118 @@ | |||
| using RustyIceberg | |||
Contributor
Author
There was a problem hiding this comment.
Refactored all scan tests into this file.
whatsthecraic
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.