Conversation
|
This has been almost a year in PR, @adamaltman does this PR still apply? |
|
Yes, it does. Hard to get a review around here. ;-) |
| enum: | ||
| - identity-proof | ||
| - address-proof | ||
| purpose: |
There was a problem hiding this comment.
Would it make sense to restrict this field to a nullable enum ?
I can not imagine too many reasons to request a KYC check (basically it can serve the purpose of accepting a customer or to send money to someone). Having an enum would also allow us to get an understanding of what is the most common use of this tool.
Also, we always can evolve from an enum to a string while the opposite would be more difficult.
I am not sure enough about all the possible values the enum could accept, though.
There was a problem hiding this comment.
It may make sense. Maybe these:
- acceptance
- remittance
- investor
- otherWhat do you think of those possible values?
There was a problem hiding this comment.
Those values seem ok to me as a starting point.
There was a problem hiding this comment.
@adamaltman Those possibilities seem okay for now. We can always add to or change the enum if needed.
3 participants
No description provided.