Open
Conversation
- Date Picker: single date and date range selection - Time Picker: hours/minutes with optional seconds - Date + Time Picker: combined datetime-local input Accessible, native HTML5 inputs; consistent with existing form components (label, hint, validation, tooltip, icon support). Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
@RealZone22 , |
Owner
|
It looks good so far. As I am currently not home, I will take a look at it on Tuesday when I am back. |
RealZone22
reviewed
Feb 18, 2026
Comment on lines
+42
to
+61
| <input | ||
| type="date" | ||
| id="{{ $uuid }}-start" | ||
| aria-label="{{ $label ? $label.' (start)' : 'Start date' }}" | ||
| @if($nameBase) name="{{ $nameBase }}_start" @endif | ||
| @if($min) min="{{ $min }}" @endif | ||
| @if($max) max="{{ $max }}" @endif | ||
| @if($placeholder) placeholder="{{ $placeholder }}" @endif | ||
| {{ $baseAttrs->twMerge($inputClass) }} | ||
| /> | ||
| <span class="text-on-surface/60 dark:text-on-surface-dark/60 text-sm shrink-0" aria-hidden="true">–</span> | ||
| <input | ||
| type="date" | ||
| id="{{ $uuid }}-end" | ||
| aria-label="{{ $label ? $label.' (end)' : 'End date' }}" | ||
| @if($nameBase) name="{{ $nameBase }}_end" @endif | ||
| @if($min) min="{{ $min }}" @endif | ||
| @if($max) max="{{ $max }}" @endif | ||
| {{ $baseAttrs->twMerge($inputClass) }} | ||
| /> |
Owner
There was a problem hiding this comment.
Can you tell me, why didn't you add support for wire:model? Maybe add two variables for start and end which will be used in wire:model
| ]) | ||
|
|
||
| @php | ||
| $uuid = $uuid ?: 'dp-'.bin2hex(random_bytes(6)); |
Owner
There was a problem hiding this comment.
I looked at other components, and as far as I know, there was a problem with using PHP variables for UUIDs. Take a look at the input component, for example. There, the UUID is generated with x-data.
| ]) | ||
|
|
||
| @php | ||
| $uuid = $uuid ?: 'dtp-'.bin2hex(random_bytes(6)); |
Owner
There was a problem hiding this comment.
Same here. Use the x-data for uuid generation
| ]) | ||
|
|
||
| @php | ||
| $uuid = $uuid ?: 'tp-'.bin2hex(random_bytes(6)); |
Owner
There was a problem hiding this comment.
Same here. Use the x-data for uuid generation
| <i class="{{ $icon }} absolute left-2.5 top-1/2 -translate-y-1/2 z-10 text-gray-500 dark:text-neutral-500 pointer-events-none"></i> | ||
| @endif | ||
|
|
||
| <div class="{{ $isRange ? 'flex flex-wrap items-center gap-2' : '' }} @if($icon) relative @endif"> |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #24
Adds reusable Date/Time Picker components as requested:
Date Picker (
x-pengublade::date-picker)mode="range")Time Picker (
x-pengublade::time-picker):seconds="true")Date + Time Picker (
x-pengublade::date-time-picker)Uses native HTML5 inputs for accessibility; follows existing component patterns (label, hint, validation, tooltip, icon).