Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rare/components/dialogs/install/dialog.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ def __init__(self, settings: RareAppSettings, rgame: "RareGame", options: Instal
save_func=self._install_dir_save_callback,
parent=self,
)
self.install_dir_edit.setReadOnly(True)
self.install_dir_edit.validationFinished.connect(self._on_install_dir_validation)
self.ui.main_layout.setWidget(
self.ui.main_layout.getWidgetPosition(self.ui.install_dir_label)[0],
Expand Down
1 change: 1 addition & 0 deletions rare/components/dialogs/move.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ def __init__(self, rcore: RareCore, rgame: RareGame, parent=None):
edit_func=self.__target_path_edit_callback,
parent=self,
)
self.target_path_edit.setReadOnly(True)
self.target_path_edit.reasons = {
MovePathEditReasons.MOVEDIALOG_DST_MISSING: self.tr("You need to provide the destination directory."),
MovePathEditReasons.MOVEDIALOG_NO_WRITE: self.tr("No write permission on destination."),
Expand Down
1 change: 1 addition & 0 deletions rare/components/tabs/integrations/egl_sync_group.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ def __init__(self, rcore: RareCore, parent=None):
save_func=self.egl_path_edit_save_cb,
parent=self,
)
self.egl_path_edit.setReadOnly(True)
self.ui.egl_sync_layout.setWidget(
self.ui.egl_sync_layout.getWidgetPosition(self.ui.egl_path_edit_label)[0],
QFormLayout.ItemRole.FieldRole,
Expand Down
17 changes: 9 additions & 8 deletions rare/components/tabs/integrations/import_group.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,17 +166,18 @@ def __init__(self, rcore: RareCore, parent=None):
self._app_titles: Dict[str, str] = {}
self._install_dirs: Set[str] = set()

self.path_edit = PathEdit(
self.import_path_edit = PathEdit(
path=self.core.get_default_install_dir(self.core.default_platform),
file_mode=QFileDialog.FileMode.Directory,
edit_func=self._path_edit_callback,
parent=self,
)
self.path_edit.textChanged.connect(self._path_changed)
self.import_path_edit.setReadOnly(True)
self.import_path_edit.textChanged.connect(self._path_changed)
self.ui.import_layout.setWidget(
self.ui.import_layout.getWidgetPosition(self.ui.path_edit_label)[0],
QFormLayout.ItemRole.FieldRole,
self.path_edit,
self.import_path_edit,
)

self.app_name_edit = IndicatorLineEdit(
Expand Down Expand Up @@ -226,7 +227,7 @@ def showEvent(self, a0: QShowEvent) -> None:
def set_game(self, app_name: str):
if app_name:
rgame = self.rcore.get_game(app_name)
self.path_edit.setText(
self.import_path_edit.setText(
os.path.join(
self.core.get_default_install_dir(rgame.default_platform),
rgame.folder_name,
Expand All @@ -248,7 +249,7 @@ def _path_changed(self, path: str):
self.info_label.setText("")
self.ui.import_folder_check.setCheckState(Qt.CheckState.Unchecked)
self.ui.import_force_check.setCheckState(Qt.CheckState.Unchecked)
if self.path_edit.is_valid:
if self.import_path_edit.is_valid:
self.app_name_edit.setText(find_app_name(self.core, path))
else:
self.app_name_edit.setText("")
Expand Down Expand Up @@ -277,7 +278,7 @@ def _app_name_changed(self, app_name: str):
self.ui.import_dlcs_check.setCheckState(Qt.CheckState.Unchecked)
self.ui.import_force_check.setCheckState(Qt.CheckState.Unchecked)
self.ui.import_dlcs_check.setEnabled(self.app_name_edit.is_valid and bool(self.core.get_dlc_for_game(app_name)))
self.ui.import_button.setEnabled(not bool(self.worker) and (self.app_name_edit.is_valid and self.path_edit.is_valid))
self.ui.import_button.setEnabled(not bool(self.worker) and (self.app_name_edit.is_valid and self.import_path_edit.is_valid))

@Slot(Qt.CheckState)
def _on_import_folder_changed(self, state: Qt.CheckState):
Expand Down Expand Up @@ -311,7 +312,7 @@ def _on_import_dlcs_changed(self, state: Qt.CheckState):

@Slot()
def _on_import_clicked(self):
self._import(self.path_edit.text())
self._import(self.import_path_edit.text())

@Slot(str)
def _import(self, path: Optional[str] = None):
Expand All @@ -321,7 +322,7 @@ def _import(self, path: Optional[str] = None):
self.button_info_stack.setCurrentWidget(self.info_progress)

if not path:
path = self.path_edit.text()
path = self.import_path_edit.text()
self.worker = ImportWorker(
self.core,
path,
Expand Down
1 change: 1 addition & 0 deletions rare/components/tabs/library/details/cloud_saves.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ def __init__(self, settings: RareAppSettings, rcore: RareCore, parent=None):
edit_func=self.edit_save_path,
save_func=self.save_save_path,
)
self.cloud_save_path_edit.setReadOnly(True)
self.cloud_ui.main_layout.setWidget(
self.cloud_ui.main_layout.getWidgetPosition(self.cloud_ui.path_label)[0],
QFormLayout.ItemRole.FieldRole,
Expand Down
1 change: 0 additions & 1 deletion rare/components/tabs/library/details/game.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ def __init__(self, rcore: RareCore, parent=None):
save_func=self.__override_exe_save_callback,
parent=self,
)
self.override_exe_edit.line_edit.setReadOnly(False)

self.launch_params_edit = QLineEdit(self)
self.launch_params_edit.setPlaceholderText(self.tr("Game specific command line arguments"))
Expand Down
2 changes: 2 additions & 0 deletions rare/components/tabs/settings/legendary.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ def __init__(self, settings: RareAppSettings, rcore: RareCore, parent=None):
edit_func=self.__path_edit_callback,
save_func=self._path_save_callback_mac,
)
self.mac_install_dir_edit.setReadOnly(True)
self.ui.install_dir_layout.addWidget(self.mac_install_dir_edit)

# Platform-independent installation directory
Expand All @@ -71,6 +72,7 @@ def __init__(self, settings: RareAppSettings, rcore: RareCore, parent=None):
edit_func=self.__path_edit_callback,
save_func=self._path_save_callback_win,
)
self.install_dir_edit.setReadOnly(True)
self.ui.install_dir_layout.addWidget(self.install_dir_edit)

# Max Workers
Expand Down
1 change: 0 additions & 1 deletion rare/components/tabs/settings/widgets/launch.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ def __init__(self, rcore: RareCore, wrapper_widget: Type[WrapperSettings], paren
edit_func=self.__prelaunch_cmd_edit_callback,
save_func=self.__prelaunch_cmd_save_callback,
)
self.prelaunch_cmd.line_edit.setReadOnly(False)

self.prelaunch_args = QLineEdit("")
self.prelaunch_args.setPlaceholderText(self.tr("Arguments to the script or program to run before the game"))
Expand Down
1 change: 1 addition & 0 deletions rare/components/tabs/settings/widgets/proton.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ def __init__(self, rcore: RareCore, parent=None):
placeholder=self.tr("Please select path for proton prefix"),
parent=self,
)
self.compat_edit.setReadOnly(True)

# self.winetricks_button = QPushButton(self.tr("Winetricks"), self)
# self.create_button = QPushButton(self.tr("Create prefix"), self)
Expand Down
2 changes: 0 additions & 2 deletions rare/components/tabs/settings/widgets/wine.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ def __init__(self, settings: RareAppSettings, rcore: RareCore, parent=None):
edit_func=self._wine_prefix_edit,
save_func=self.save_prefix,
)
self.wine_prefix_edit.line_edit.setReadOnly(False)

# Wine executable
self.wine_execut_edit = PathEdit(
Expand All @@ -48,7 +47,6 @@ def __init__(self, settings: RareAppSettings, rcore: RareCore, parent=None):
),
save_func=self.save_execut,
)
self.wine_execut_edit.line_edit.setReadOnly(False)

layout = QFormLayout(self)
layout.addRow(self.tr("Executable"), self.wine_execut_edit)
Expand Down
8 changes: 4 additions & 4 deletions rare/widgets/indicator_edit.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,7 @@ def __init__(
layout = QHBoxLayout(self)
layout.setObjectName(f"{self.objectName()}Layout")
layout.setContentsMargins(0, 0, 0, 0)
layout.setSizeConstraints(
QHBoxLayout.SizeConstraint.SetDefaultConstraint, QHBoxLayout.SizeConstraint.SetFixedSize
)
layout.setSizeConstraint(QHBoxLayout.SizeConstraint.SetDefaultConstraint)
# Add line_edit
self.line_edit = QLineEdit(self)
self.line_edit.setObjectName(f"{type(self).__name__}Edit")
Expand Down Expand Up @@ -371,7 +369,6 @@ def __init__(
)
self.setObjectName(type(self).__name__)
self.line_edit.setMinimumSize(QSize(250, 0))
self.line_edit.setReadOnly(True)
self.path_select = QPushButton(self)
self.path_select.setObjectName(f"{type(self).__name__}Button")
layout = self.layout()
Expand All @@ -385,6 +382,9 @@ def __init__(

self.path_select.clicked.connect(self.__set_path)

def setReadOnly(self, read_only: bool):
self.line_edit.setReadOnly(read_only)

def setRootPath(self, path: str):
self.__root_path = path
self.__completer_model.setRootPath(path)
Expand Down