Part 1: Add replication source and destination controllers by Rakshith-R · Pull Request #12 · RamenDR/ceph-volsync-plugin

Rakshith-R · 2026-03-06T05:15:07Z

Part 1: Add replication source and destination controllers

Add manager with controller setup and openshift SCC manifest
- https://github.com/backube/volsync/blob/v0.11.0/main.go#L66
- https://github.com/backube/volsync/blob/v0.11.0/config/openshift/mover_scc.yaml
Add mover builder package for mover catalog
- https://github.com/backube/volsync/blob/v0.11.0/controllers/mover/builder.go
- need custom builder to store local catalog of movers (cephfs.etc)
- movers (statemachine that manages resources) will be added in follow-up pr
Add replication source and destination controllers
- Initiates the mover
- Almost the same as original controllers with minor changes as required for reconciling custom mover.
- https://github.com/backube/volsync/blob/v0.11.0/controllers/replicationsource_controller.go
- https://github.com/backube/volsync/blob/v0.11.0/controllers/replicationdestination_controller.go
use golang 1.25 for mover
e2e: modify golangci lint to auto detect golang version

Will be followed by or in parallel to the following parts in separate prs.

Part 2: Movers (reconcile job and associated resources)
Part 3: Workers (source client and destination server)
Part 4: e2e

Madhu-1 · 2026-03-09T05:56:14Z

cmd/openshift/mover_scc.yaml

@@ -0,0 +1,39 @@
+---


Why do we need two mover_scc? One is here, and another is in cmd/manager. i assume its a mistake?

Yes, my mistake.
Removing this.

Madhu-1 · 2026-03-09T05:58:05Z

internal/controller/replicationdestination_controller.go

+	instance := &volsyncv1alpha1.ReplicationDestination{}
+	if err := r.Get(ctx, req.NamespacedName, instance); err != nil {
+		if !kerrors.IsNotFound(err) {
+			logger.Error(err, "Failed to get Destination")


return is missing here?

added a comment.

same return is used in line 95 below, client.IgnoreNotFound(err) will make the error nil.

Madhu-1 · 2026-03-09T06:10:28Z

internal/mover/builder.go

+	destination *volsyncv1alpha1.ReplicationDestination, privileged bool) (mover.Mover, error) {
+	var dataMover mover.Mover
+	for _, builder := range Catalog {
+		candidate, err := builder.FromDestination(client, logger, eventRecorder, destination, privileged)


what about the error handling here?

Followed same pattern as here
https://github.com/backube/volsync/blob/1a7616613085863d5fcc108d06cd47827d660f24/internal/controller/mover/builder.go#L102-L111

but will add a error log here now
We should not be hitting an error in our plugin.

Madhu-1 · 2026-03-09T06:11:53Z

internal/controller/replicationsource_controller.go

+// +kubebuilder:rbac:groups=rbac.authorization.k8s.io,resources=roles,verbs=get;list;watch;create;update;patch;delete;escalate;bind
+// +kubebuilder:rbac:groups=rbac.authorization.k8s.io,resources=rolebindings,verbs=get;list;watch;create;update;patch;delete;escalate;bind
+// +kubebuilder:rbac:groups=rbac.authorization.k8s.io,resources=clusterrolebindings,verbs=get;list;watch;create;update;patch;delete;escalate;bind
+// +kubebuilder:rbac:groups=security.openshift.io,resources=securitycontextconstraints,resourceNames=volsync-privileged-mover,verbs=use


volsync-privileged-mover is not the SCC we are creating, its ceph-volsync-plugin-privileged-mover

Madhu-1 · 2026-03-09T06:12:08Z

internal/controller/replicationdestination_controller.go

+// +kubebuilder:rbac:groups=rbac.authorization.k8s.io,resources=roles,verbs=get;list;watch;create;update;patch;delete;escalate;bind
+// +kubebuilder:rbac:groups=rbac.authorization.k8s.io,resources=rolebindings,verbs=get;list;watch;create;update;patch;delete;escalate;bind
+// +kubebuilder:rbac:groups=rbac.authorization.k8s.io,resources=clusterrolebindings,verbs=get;list;watch;create;update;patch;delete;escalate;bind
+// +kubebuilder:rbac:groups=security.openshift.io,resources=securitycontextconstraints,resourceNames=volsync-privileged-mover,verbs=use


wrong SCC name?

made a generic scaffolding below.
forgot to remove this 😮‍💨

Will be removed.

Madhu-1 · 2026-03-09T06:14:11Z

internal/controller/replicationsource_controller.go

+// +kubebuilder:rbac:groups=volsync.backube,resources=replicationsources/status,verbs=get;update;patch
+// +kubebuilder:rbac:groups=batch,resources=jobs,verbs=get;list;watch;create;update;patch;delete;deletecollection
+// +kubebuilder:rbac:groups=core,resources=events,verbs=create;update;patch
+// +kubebuilder:rbac:groups=apps,resources=nodes,verbs=get;list;watch


node group is "" not app?

Madhu-1 · 2026-03-09T06:14:44Z

cmd/manager/main.go

 	setupLog = ctrl.Log.WithName("setup")
+
+	//go:embed openshift/mover_scc.yaml
+	CephVolsyncPluginMoverSCCYamlRaw []byte


no need to export this as its not used outside?

Madhu-1 · 2026-03-09T06:15:25Z

internal/mover/builder.go

+	ErrNoMoverFound        = fmt.Errorf("a replication method must be specified")
+	ErrMultipleMoversFound = fmt.Errorf("only one replication method can be supplied")


use errors.New?

Madhu-1 · 2026-03-09T06:16:01Z

internal/mover/builder.go

+	var dataMover mover.Mover
+	for _, builder := range Catalog {
+		candidate, err := builder.FromSource(client, logger, eventRecorder, source, privileged)
+		if err == nil && candidate != nil {


what about the err!=nil case?

Followed same pattern as here
https://github.com/backube/volsync/blob/1a7616613085863d5fcc108d06cd47827d660f24/internal/controller/mover/builder.go#L102-L111

but will add a error log here now
We should not be hitting an error in our plugin.

Madhu-1 · 2026-03-09T06:17:05Z

internal/controller/replicationsource_controller.go

+
+// Reconcile is part of the main kubernetes reconciliation loop which aims to
+// move the current state of the cluster closer to the desired state.
+// TODO(user): Modify the Reconcile function to compare the state specified by


update the comment?

removed the comment

Signed-off-by: Rakshith R <rar@redhat.com>

Rakshith-R requested a review from Madhu-1 March 6, 2026 05:17

Madhu-1 reviewed Mar 9, 2026

View reviewed changes

Rakshith-R added 5 commits March 9, 2026 16:20

Add manager with controller setup and openshift SCC manifest

ea79793

Signed-off-by: Rakshith R <rar@redhat.com>

Add mover builder package for mover catalog

84d5246

Signed-off-by: Rakshith R <rar@redhat.com>

Add replication source and destination controllers

2a1b9ff

Signed-off-by: Rakshith R <rar@redhat.com>

use golang 1.25 for mover

85eac82

Signed-off-by: Rakshith R <rar@redhat.com>

e2e: modify golangci lint to auto detect golang version

342967a

Signed-off-by: Rakshith R <rar@redhat.com>

Rakshith-R force-pushed the add-controllers branch from 3058f83 to 342967a Compare March 9, 2026 10:50

Rakshith-R requested a review from Madhu-1 March 9, 2026 10:59

Madhu-1 approved these changes Mar 10, 2026

View reviewed changes

Madhu-1 merged commit fafc6b7 into RamenDR:main Mar 10, 2026
7 checks passed

		ErrNoMoverFound = fmt.Errorf("a replication method must be specified")
		ErrMultipleMoversFound = fmt.Errorf("only one replication method can be supplied")

Conversation

Rakshith-R commented Mar 6, 2026

Part 1: Add replication source and destination controllers

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants