Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 4, 2026

The test_get_other_triton.py and related test files were calling iris.get() with swapped from_rank and to_rank parameters, causing all parameterized test cases to fail.

Root Cause

The function signature is:

iris.get(from_ptr, to_ptr, from_rank, to_rank, heap_bases, ...)

Tests were incorrectly passing cur_rank, target_rank when they should pass target_rank, cur_rank to read from the target rank into the current rank's local memory.

Changes

  • test_get_other_triton.py: Swapped cur_rank and target_rank in iris.get() call
  • test_get_cache_modifiers.py: Fixed parameter order in all four iris.get() call sites
  • test_get_triton.py: Fixed parameter order in iris.get() call
# Before
iris.get(data + offsets, results + offsets, cur_rank, target_rank, heap_bases, ...)

# After
iris.get(data + offsets, results + offsets, target_rank, cur_rank, heap_bases, ...)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits February 4, 2026 17:48
Co-authored-by: neoblizz <9790745+neoblizz@users.noreply.github.com>
…n.py

Co-authored-by: neoblizz <9790745+neoblizz@users.noreply.github.com>
Copilot AI changed the title [WIP] Introduce cache modifiers for distributed memory operations Fix parameter order in iris.get() test calls Feb 4, 2026
Copilot AI requested a review from neoblizz February 4, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants