Fix parameter order in iris.get() test calls #357
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_get_other_triton.pyand related test files were callingiris.get()with swappedfrom_rankandto_rankparameters, causing all parameterized test cases to fail.Root Cause
The function signature is:
Tests were incorrectly passing
cur_rank, target_rankwhen they should passtarget_rank, cur_rankto read from the target rank into the current rank's local memory.Changes
cur_rankandtarget_rankiniris.get()calliris.get()call sitesiris.get()call💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.