-
Notifications
You must be signed in to change notification settings - Fork 33
Add tritonBLAS as dependency #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modernizes tritonBLAS integration by adding it as a proper pip dependency instead of requiring manual installation. The change simplifies the build process by leveraging tritonBLAS's new support for standard pip installation.
Changes:
- Added tritonBLAS as a git-based pip dependency in pyproject.toml
- Removed manual tritonBLAS cloning and installation from Docker and Apptainer container definitions
- Removed manual tritonBLAS installation scripts from CI workflows and test runners
- Cleaned up environment variables related to manual tritonBLAS installation paths
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Added tritonBLAS as git dependency at specific commit |
| docker/Dockerfile | Removed manual tritonBLAS clone and installation steps |
| apptainer/iris.def | Removed tritonBLAS installation code and cleaned up PYTHONPATH |
| .github/workflows/iris-external-validation-test.yml | Removed manual tritonBLAS installation from both validation test jobs |
| .github/scripts/run_tests.sh | Removed tritonBLAS installation check and manual installation fallback |
| .github/scripts/run_perf_benchmark.sh | Removed manual tritonBLAS installation from benchmark runner |
| export TRITONBLAS_PATH=/opt/tritonBLAS | ||
| export ROCM_PATH=/opt/rocm | ||
| export PYTHONPATH=$TRITON_PATH:$TRITONBLAS_PATH | ||
| export PYTHONPATH=$TRITON_PATH |
Copilot
AI
Feb 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TRITONBLAS_PATH environment variable was removed from the %environment section (line 42) and from PYTHONPATH, but it's still being set in the %post section at line 11 of the file. For consistency, line 11 should also be removed since tritonBLAS is now installed as a regular pip dependency and doesn't need a dedicated path.
| "numpy", | ||
| "requests", | ||
| "ruff", | ||
| "tritonblas @ git+https://github.com/ROCm/tritonBLAS.git@f9ce75408bbeef091a7a47c156e15629f4670595", |
Copilot
AI
Feb 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description states the upgrade is to commit d0b4a6b, but the actual commit hash used in pyproject.toml is f9ce75408bbeef091a7a47c156e15629f4670595. Please verify this is the correct commit hash and update the PR description accordingly, or correct the commit hash in pyproject.toml if the description is accurate.
tritonBLAS now supports proper pip install. Add it as a dependency and remove manual installation from CI/container configs.
Changes
tritonblasas git dependency pointing to commitd0b4a6b(includes pip install fix from tritonBLAS#58)run_tests.shandrun_perf_benchmark.shiris-external-validation-test.ymldocker/Dockerfileandapptainer/iris.defNotes
47768c9tod0b4a6bto use version with proper package discoveryTRITONBLAS_PATHenvironment variable from Apptainer (no longer needed)Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.