Replace deprecated bit32 library with Lua BitOp#389
Open
Maaggs wants to merge 1 commit intoQuantumEntangledAndy:masterfrom
Open
Replace deprecated bit32 library with Lua BitOp#389Maaggs wants to merge 1 commit intoQuantumEntangledAndy:masterfrom
Maaggs wants to merge 1 commit intoQuantumEntangledAndy:masterfrom
Conversation
Maaggs
force-pushed
the
wireshark-dissector-broken-due-to-deprecated-function-use
branch
from
e432015 to
7ba8d3e
Compare
This is in accordance with the '13.17. Bitwise Operations' chapter of the Wireshark's Lua API Reference Manual. Using the Lua BitOp library instead of the native bitwise operators provides maximum backwards compatibility and avoids potential issues arising from the use of 64-bit integers by default with the native operators. Fix QuantumEntangledAndy#388
Maaggs
force-pushed
the
wireshark-dissector-broken-due-to-deprecated-function-use
branch
from
7ba8d3e to
19ffb41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in accordance with the '13.17. Bitwise Operations' chapter of the Wireshark's Lua API Reference Manual. Using the Lua BitOp library instead of the native bitwise operators provides maximum backwards compatibility and avoids potential issues arising from the use of 64-bit integers by default with the native operators.
Fix #388