-
Notifications
You must be signed in to change notification settings - Fork 139
fix: add volume functions for Corning 96-well flat and V-bottom plates #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
margaretsantiago
wants to merge
3
commits into
PyLabRobot:main
Choose a base branch
from
margaretsantiago:fix/corning-costar-bottom-types-and-volume-functions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the spec says 6.86 for the top diamater, let's use the widest part
where did you find 6.37?
how did you find the cone and cylinder height?
dx Is 14.38 - well_size/2
let's use the defined constants wherever possible
how did you find material_z_thickness?
https://www.corning.com/catalog/cls/documents/drawings/DWG00848.PDF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Rick,
Thank you for the thorough review. Going through each one:
"the spec says 6.86 for the top diameter, let's use the widest part” — that works. I’ll recalculate using 6.86 instead of 6.37. I’ve also created a separate file for my own reference to account for both top and bottom diameters based on manufacturer’s specs. This way I can continuously cross-reference various specs with bench data and physical tests, using different liquids. I plan to collect data on cone-height, cone-angles, height of V section.
“where did you find 6.37?” From Corning’s website, Corning Microplate Dimensions PDF lists top and bottom diameters across varying microplates.
"dx Is 14.38 - well_size/2” — Sounds good. The use of 14.3 came directly from Corning’s website, Corning Microplate Dimensions PDF
"how did you find the cone and cylinder height?” Cone height — was back calculated to match 320uL total volume. Cylinder height — I used Corning’s “well depth” measurement (see link above) and subtracted cone height
"let's use the defined constants wherever possible” - Let’s do that.
"how did you find material_z_thickness?” — I received data from a research student who measured a cross-section of a 96-well v-bottom plate that was going to be disposed. I do plan to take my own physical measurements as soon as the plates arrive.
CorningMicroplateDimensions.pdf