Improve and simplify the CommaProxyList algorithm.#146
Open
duncf wants to merge 1 commit intoPyCQA:masterfrom
Open
Improve and simplify the CommaProxyList algorithm.#146duncf wants to merge 1 commit intoPyCQA:masterfrom
duncf wants to merge 1 commit intoPyCQA:masterfrom
Conversation
With this change CommaProxyList better handles and preserves non-standard (and even inconsistent) indentation, rather than assuming indented lists are indented by four spaces (fixes PyCQA#100). It also is significantly faster in very large files by avoiding use of ".indentation", which can require iterating over every element in the file. End-of-list comments are preserved at the end of the list, and inline comments are also preserved.
|
I have the same issue, could this please be merged? |
|
@Psycojoker, could you take a look at this? |
|
@Psycojoker, could you reconsider merging this and #145? It dramatically improves the performance of the CommaProxyList algorithm. |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change CommaProxyList better handles and preserves non-standard (and
even inconsistent) indentation, rather than assuming indented lists are indented
by four spaces (fixes #100). It also is significantly faster in very large files
by avoiding use of ".indentation", which can require iterating over every
element in the file. End-of-list comments are preserved at the end of the list,
and inline comments are also preserved.