Re-Implement V-slice like holds#317
Open
DerpyTheHedgeone wants to merge 19 commits intoPsych-Slice:master-devfrom
Open
Re-Implement V-slice like holds#317DerpyTheHedgeone wants to merge 19 commits intoPsych-Slice:master-devfrom
DerpyTheHedgeone wants to merge 19 commits intoPsych-Slice:master-devfrom
Conversation
this is the intended hold note animation
fix roses dialogue bleep for bf that doesnt have the correct sound for it
fix roses dialogue bleep that bf lacks safe edition
fix the left and right notes of monster to better fit v-slice
up loop isnt offset
temporarily revert v-slice like holds
this is the intended way since 0.6.X
revert this
revert this
rever this
revert it pls!
why isnt it reverting
ITS NOT WORKING
normal version
KELOTOMU
suggested changes
Feb 21, 2026
KELOTOMU
left a comment
KELOTOMU
left a comment
There was a problem hiding this comment.
Set the noAnimation property inside the Note.hx class instead of changing them inside PlayState.hx
Contributor
Author
why though? it works fine as it is |
Because it's way more cleaner, and also so that it could always be safely edited by any means of other scripts, and objectively faster |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is the intended way since 0.6.X
#276