chore(deps): upgrade ESLint 8 → 10 (flat config) and chai 4 → 6#1934
Merged
chore(deps): upgrade ESLint 8 → 10 (flat config) and chai 4 → 6#1934
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Migrate ESLint to flat config format (eslint.config.mjs), remove .eslintrc. Upgrade chai to v6 which includes built-in TypeScript types, remove @types/chai. - Replace eslint-plugin-import with eslint-plugin-import-x (ESLint 10 compatible fork) - Add typescript-eslint unified package for flat config support - Disable import-x/no-unused-modules (incompatible with ESLint 10) - Add test file overrides for chai expressions and sinon namespace - Remove --ext flag from eslint scripts (not supported in flat config) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add .claude/** to ESLint ignores (worktree dirs were being linted) - Remove unused eslint-disable directive in assets.ts (import-x/no-unresolved) - Re-add @types/chai (chai 6 does not ship built-in types) - Auto-fix prettier formatting in eslint.config.mjs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ryanio
force-pushed
the
chore/upgrade-eslint-chai
branch
from
d3adfef to
93eb9db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eslint.config.mjs), removed.eslintrc.js. Replacedeslint-plugin-importwitheslint-plugin-import-x(maintained fork compatible with ESLint 10). Addedtypescript-eslintunified package for flat config support. Installedglobalspackage to replaceenvconfiguration.@types/chaias it is no longer needed.--ext .js,.tsflag from eslint scripts (not supported in flat config)import-x/no-unused-modulesrule (uses internal ESLint APIs removed in v10)@typescript-eslint/no-unused-expressions(chai assertions) andimport-x/namespace(sinon)eslint-disablecomments for the oldimport/no-unused-modulesruleTest results
npx eslint . --max-warnings 0— passes clean (0 errors, 0 warnings)npm test— 571 passing, 1 failing (pre-existing failure due to missing typechain generated code, same on base branch)npx tsc --noEmit— same pre-existing typechain error as base branchDependencies
This PR is based on #1933 (low-risk dep upgrades).
🤖 Generated with Claude Code