fix(security): redact API key from logs + audit fix dev deps#1931
Merged
fix(security): redact API key from logs + audit fix dev deps#1931
Conversation
The logger serialized the full request headers including X-API-KEY, which could expose the key in console logs, log files, or observability tools. Strip the key before logging. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Resolves 8 of 10 dev dependency vulnerabilities (ReDoS in minimatch, babel, ajv, brace-expansion, diff; prototype pollution in lodash, js-yaml). Remaining 2 (serialize-javascript via mocha) require a breaking major version upgrade. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/api/api.tswas serializing the fullreq.headers(includingX-API-KEY) into the logger. Stripped the key before logging so it doesn't leak to console, log files, or observability tools.Test plan
X-API-KEYnpm test)npm auditshows only 2 remaining high-severity issues (mocha/serialize-javascript)🤖 Generated with Claude Code