fix: add ORDER event type to AssetEventType enum#1929
Merged
Conversation
The API returns event_type "order" for all order-related activities (listings, offers, trait offers, collection offers). Add the ORDER enum value and a corresponding OrderEvent response type. Note: "order" is a response-only value and should not be used as a query filter in GetEventsArgs. Co-Authored-By: Muhammad Minhaj <developer.mdminhaj@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ORDER = "order"toAssetEventTypeenum to match API response valuesOrderEventtype for order-related activity eventsOrderEventto theAssetEventunion typeThe API returns
event_type: "order"for all order-related activities (listings, offers, trait offers, collection offers). This was missing from the SDK, causing consumers to be unable to match on these events.Based on #1927 by @MuhammadMinhaj — thank you for identifying this gap!
Test plan
OrderEventtype correctly represents API response shape🤖 Generated with Claude Code