Fix API reference examples to use correct camelCase properties#1917
Merged
Fix API reference examples to use correct camelCase properties#1917
Conversation
Only three fields actually have camelCase converters in the SDK: - collection.totalSupply (via collectionFromJSON) - account.profileImageUrl (via accountFromJSON) - token.usdPrice (via paymentTokenFromJSON) Other fields (nft.image_url, contract.contract_standard, stats.total.floor_price, event.event_timestamp) are returned as-is from the API without conversion. Based on #1911 by @pineapplepeak — corrected to only fix the fields that actually have camelCase converters. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collection.totalSupply,account.profileImageUrl,token.usdPricenft.image_url,contract.contract_standard,stats.total.floor_price,event.event_timestamp)Built on top of #1911 by @pineapplepeak — refined to only fix fields that actually have camelCase converters in the SDK. The original PR proposed 7 changes, but 4 of them would have been incorrect since those types have no snake_case → camelCase converter.
Test plan
src/types.ts,src/api/types.ts, andsrc/utils/converters.ts🤖 Generated with Claude Code