feat(experiments): add missing experimentation tools.#123
Conversation
18a74ac to
80ab599
Compare
joshsny
left a comment
There was a problem hiding this comment.
Looks great 🙌
Left some small comments to address and then think we're good to merge it in. Do we want to do experiment-update / experiment-delete tools in a different PR?
joshsny
left a comment
There was a problem hiding this comment.
Oh and we'll need to add integration tests for the changes to the API client and for the new tools :)
|
@joshsny ! Thanks for the review! I'll get your feedback in and let you know when it's ready for another review! This PR got a bit large, so |
|
@rodrigoi FYI there are some issues currently with integration tests, so if those are failing you can ignore that for now, they are having intermittent failure issues |
9cc87df to
8d390da
Compare
|
@joshsny This is ready for another review. I caved and added the |
joshsny
left a comment
There was a problem hiding this comment.
Super nice, can't wait to get this merged, left some small comments before merging :)
|
@rodrigoi tested this locally and it works well for me! |
|
@rodrigoi pushed a |
…e and generating python schema.
…sformations and parsing.
…od schemas, transformations and derived types.
…tterns as the create tool.
5213279 to
ba9076f
Compare
|
@joshsny I did a whole refactor pass over the schema to make more... idiomatic Zod, and removed some of the duplication. Updated integration tests (we need to update the scope of the token we are using today), rebased, and tested extensively, but I would like your final approval before merging 😉 |
joshsny
left a comment
There was a problem hiding this comment.
Looks great! Let's ship it 🚢 🙌
|
Updated the API key and the integration tests are passing now, so we should be good to go 🚢 |
Problem
The MCP tool is missing some key tooling for retrieve experiment exposures, results and to create and update experiments.
Changes
We've added new tools to the MCP server to complete the loop of experiment manipulation tools:
experiment-exposure-queryThis tool enables LLMs to access the complete exposure time series using the
experimentId.experiment-metric-results-getThis tool enables LLMs to get the complete set of metric results to provide analysis and interpretation of those results.
experiment-createThis tool allows LLMs to create experiments after querying the user for a hypothesis, feature flags and events.
How did you test this code?