feat(ApiManager): web support#17
Open
andrelucassvt wants to merge 3 commits intoPopcodeMobile:mainfrom
Open
Conversation
samukazangetsu
approved these changes
Oct 1, 2025
ThiagoMartinsPopCode
approved these changes
Oct 1, 2025
Ascenio
reviewed
Oct 2, 2025
|
|
||
| dependencies: | ||
| dio: ^5.8.0+1 | ||
| foundation: ^0.0.5 |
There was a problem hiding this comment.
Esse aqui é um package abandonado.
Suggested change
| foundation: ^0.0.5 |
Contributor
There was a problem hiding this comment.
Verdade! Apesar do kIsWeb dentro da lib ser algo simples, é melhor usar direto a comparação pura, sem a lib
Pode remover a dependência e substituir o kIsWeb por bool.fromEnvironment('dart.library.js_util'), que verifica se tem um js.util rodando no ambiente
There was a problem hiding this comment.
O package foundation do próprio flutter já tem o kIsWeb então tá tranquilo, bastaria remover essa linha aqui, nem precisa mexer no código 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Suporte ao WEB
💻 Adicionado suporte ao web nas requisições
Descrição do envio aqui
Para testar, faça ....
📷 Screenshots
Checklist