Open
Conversation
ashishthakur913
suggested changes
Oct 12, 2022
src/components/Checkbox/Checkbox.tsx
Outdated
| transition: `200ms`, | ||
| boxSizing: 'border-box', | ||
| border: `2px solid ${theme.COLOR.gray3}`, | ||
| border: `2px solid ${disabled ? 'blue' : 'red'}`, |
Contributor
There was a problem hiding this comment.
We need to pull the color codes from the new theme instead of hardcoding them.
src/components/Checkbox/Checkbox.tsx
Outdated
|
|
||
| [`${Input}:focus + &`]: { | ||
| borderColor: theme.COLOR.brandMain, | ||
| border: `2px solid #5B9EF8`, |
Contributor
There was a problem hiding this comment.
Please check for hardcoded color name
src/components/Checkbox/Checkbox.tsx
Outdated
|
|
||
| [`${Input}:checked:focus + &`]: { | ||
| borderColor: theme.COLOR.gray5, | ||
| border: `2px solid #5B9EF8`, |
Contributor
There was a problem hiding this comment.
Please check for hardcoded color name
src/components/Checkbox/Checkbox.tsx
Outdated
| left: '5px', | ||
| right: '5px', | ||
| bottom: '5px', | ||
| border: '115px solid #ffea00' |
Contributor
There was a problem hiding this comment.
Please check for hardcoded color name
There was a problem hiding this comment.
Hey, what you mean here?
To extract into a variable?
changed main theme
changed default to basic
fixed ts error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
ACORN-939 Checkbox(link)
Proposed Changes
added new UI component checkbox
Checklist
Updated ticket in Jira
Screenshots/Screen Recording