This repository was archived by the owner on Jul 6, 2022. It is now read-only.
Have securityTokenRegistrar check namespaceRegistrar before allowing a ticker name to be registered #198
Open
win2win wants to merge 5 commits intoPolymathNetwork:masterfrom
Open
Have securityTokenRegistrar check namespaceRegistrar before allowing a ticker name to be registered #198win2win wants to merge 5 commits intoPolymathNetwork:masterfrom
win2win wants to merge 5 commits intoPolymathNetwork:masterfrom
Conversation
Contributor
|
@win2win can you please fix the test cases |
adamdossa
reviewed
Feb 27, 2018
Contributor
adamdossa
left a comment
adamdossa
left a comment
There was a problem hiding this comment.
Couple of comments:
- please could you factor out an interface for the NameSpaceRegistrar contract.
- the code should also check that, for registrations which haven't expired, the owner passed into createSecurityToken matches the owner registered against the symbol in NameSpaceRegistrar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know if those changes address the checking of ticker verification when registering new ST.