Reapply #2095 and fix reconnection error cause by it#2134
Open
NetsuNegi wants to merge 3 commits intoPhobos-developers:developfrom
Open
Reapply #2095 and fix reconnection error cause by it#2134NetsuNegi wants to merge 3 commits intoPhobos-developers:developfrom
NetsuNegi wants to merge 3 commits intoPhobos-developers:developfrom
Conversation
NetsuNegi
added
Needs testing
⚙️T1
|
To Chinese users:
|
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
secsome
requested changes
Mar 13, 2026
| } | ||
| } | ||
| else | ||
| { |
secsome
reviewed
Mar 13, 2026
| } | ||
| } | ||
| else | ||
| { |
Member
There was a problem hiding this comment.
else
{
pSource->SendToFirstLink(RadioCommand::NotifyUnlink);
}to
else
pSource->SendToFirstLink(RadioCommand::NotifyUnlink);
Contributor
There was a problem hiding this comment.
I think it should be in line with the if statement, so the bracket could be kept
Contributor
|
didn't desync in our test so far, and the previous issues are solved. More testing is appreciated tho |
Coronia
added
Tested
and removed
Needs testing
Needs MP testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.