Skip to content

[Minor] Adjust Gatling weapon selection#2133

Open
Coronia wants to merge 3 commits intoPhobos-developers:developfrom
Coronia:gatling-targeting
Open

[Minor] Adjust Gatling weapon selection#2133
Coronia wants to merge 3 commits intoPhobos-developers:developfrom
Coronia:gatling-targeting

Conversation

@Coronia
Copy link
Contributor

@Coronia Coronia commented Mar 11, 2026

the current gatling weapon selection logic will only check if the target is vulnerable to odd weapon, and simply switch to secondary if it doesn't. This will create issue when both odd and even weapons are not supposed to attack the target. E.g. odd weapon's warhead is 0% vs a ground target, then the even weapon will fire even if it has AG=no in its projectile. This pull request make it follow the process that other weapon selection is using, which is checking if even weapon is available first and then odd weapon

also fixed & regulated a few things in weapon selection

@Coronia Coronia added Needs testing Minor Minor feature and/or fix, not a lot of changes or they are not significant ⚙️T1 T1 maintainer review is sufficient No Documentation Needed No documentation needed whatsoever labels Mar 11, 2026
@github-actions
Copy link

github-actions bot commented Mar 11, 2026

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Minor Minor feature and/or fix, not a lot of changes or they are not significant Needs testing No Documentation Needed No documentation needed whatsoever ⚙️T1 T1 maintainer review is sufficient

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant