[Minor] Adjust Gatling weapon selection#2133
Open
Coronia wants to merge 3 commits intoPhobos-developers:developfrom
Open
[Minor] Adjust Gatling weapon selection#2133Coronia wants to merge 3 commits intoPhobos-developers:developfrom
Coronia wants to merge 3 commits intoPhobos-developers:developfrom
Conversation
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the current gatling weapon selection logic will only check if the target is vulnerable to odd weapon, and simply switch to secondary if it doesn't. This will create issue when both odd and even weapons are not supposed to attack the target. E.g. odd weapon's warhead is 0% vs a ground target, then the even weapon will fire even if it has AG=no in its projectile. This pull request make it follow the process that other weapon selection is using, which is checking if even weapon is available first and then odd weapon
also fixed & regulated a few things in weapon selection