Constants added

[ravishanigarapu]

📋 Description

JIRA ID:

Please provide a summary of the change and the motivation behind it. Include relevant context and details.

---

✅ Type of Change

• 🐞 Bug fix (non-breaking change which resolves an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 🛠 Refactor (change that is neither a fix nor a new feature)
• ⚙️ Config change (configuration file or build script updates)
• 📚 Documentation (updates to docs or readme)
• 🧪 Tests (adding new or updating existing tests)
• 🎨 UI/UX (changes that affect the user interface)
• 🚀 Performance (improves performance)
• 🧹 Chore (miscellaneous changes that don't modify src or test files)

---

ℹ️ Additional Information

Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.

Summary by CodeRabbit

• New Features

  • Centralized commonly used header and token names into a single location for improved consistency.

• Bug Fixes

  • Prevented the addition of null JWT token headers to outgoing requests.

• Refactor

  • Replaced hardcoded header and token names with centralized constants for better maintainability.

[coderabbitai]

Walkthrough

A new Constants class was introduced to centralize string constants for JWT token, User-Agent, and OkHttp identifiers. Existing usages of these literals in header handling and user-agent checks were refactored to use the new constants. A null check was added before propagating the JWT token header in outgoing requests.

Changes

File(s)	Change Summary
.../utils/Constants.java	Added new Constants class with static string constants and a private constructor.
.../utils/JwtUserIdValidationFilter.java	Replaced hardcoded header and user-agent strings with Constants references. Removed unused variable.
.../utils/RestTemplateUtil.java	Replaced hardcoded JWT header string with constant and added null check before adding header.

Poem

In the warren of code, constants now dwell,
No more stringy tangles, all is quite well.
JWT and User-Agent, neat in their place,
OkHttp’s a constant, no wild goose chase.
With checks for the nulls and headers aligned,
This rabbit hops forward, with tidier mind!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 74d8ebf and 02857e8.

📒 Files selected for processing (3)

• src/main/java/com/iemr/mmu/utils/Constants.java (1 hunks)
• src/main/java/com/iemr/mmu/utils/JwtUserIdValidationFilter.java (3 hunks)
• src/main/java/com/iemr/mmu/utils/RestTemplateUtil.java (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (2)

src/main/java/com/iemr/mmu/utils/RestTemplateUtil.java (1)

src/main/java/com/iemr/mmu/utils/Constants.java (1)

• Constants (3-10)

src/main/java/com/iemr/mmu/utils/JwtUserIdValidationFilter.java (1)

src/main/java/com/iemr/mmu/utils/Constants.java (1)

• Constants (3-10)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (java)

🔇 Additional comments (6)

src/main/java/com/iemr/mmu/utils/Constants.java (1)

3-10: LGTM! Well-implemented utility class with proper encapsulation.

The Constants class follows Java best practices:

• Uses public static final for constants
• Has a private constructor to prevent instantiation
• Centralizes commonly used string literals

However, note the mixed case in JWT_TOKEN = "Jwttoken" - ensure this matches the existing header name convention used throughout the application.

src/main/java/com/iemr/mmu/utils/RestTemplateUtil.java (1)

42-43: Excellent defensive programming improvement!

The added null check before propagating the JWT token header prevents null values from being added to outgoing requests. This is a robust improvement over the previous unconditional header addition. The use of Constants.JWT_TOKEN also improves maintainability by centralizing the header name definition.

src/main/java/com/iemr/mmu/utils/JwtUserIdValidationFilter.java (4)

70-70: Good refactoring to use centralized constants.

Replacing the hardcoded "JwtToken" string with Constants.JWT_TOKEN improves maintainability and consistency across the codebase.

---

90-90: Consistent use of constants for header names.

Using Constants.USER_AGENT instead of the hardcoded "User-Agent" string maintains consistency with the centralization effort.

---

115-115: Mobile client detection uses centralized constant.

The replacement of hardcoded "okhttp" with Constants.OKHTTP is consistent with the refactoring goals and improves maintainability.

---

121-121:

Details

✅ Verification successful

Verify case-insensitive comparison still works correctly.

The cookie name comparison now uses Constants.JWT_TOKEN which has the value "Jwttoken". Ensure this case-insensitive comparison (equalsIgnoreCase) still matches existing cookies that might have been set with different casing.

---

🏁 Script executed:

#!/bin/bash
# Description: Search for any other JWT token cookie references to ensure consistency
# Expected: Find usages to verify the casing is consistent

rg -i "jwttoken" --type java -A 2 -B 2

Length of output: 9327

---

Case-insensitive JWT cookie check is safe and consistent

All occurrences of the JWT cookie name in the codebase use the exact “Jwttoken” casing when setting and reading cookies (in RestTemplateUtil, CookieUtil, CommonServiceImpl, etc.). Using equalsIgnoreCase(Constants.JWT_TOKEN) will continue matching those cookies without issue and preserves backward compatibility.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud