chore(swagger): automate swagger sync to amrit-docs#115
chore(swagger): automate swagger sync to amrit-docs#115DurgaPrasad-54 wants to merge 2 commits intoPSMRI:mainfrom
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThis pull request introduces a Swagger profile and automation for synchronizing API documentation. It adds a GitHub Actions workflow to build the API and push generated Swagger JSON to the AMRIT-Docs repository, configures an H2 in-memory database for the Swagger profile, and conditionally disables Redis and HTTP interceptor when the swagger profile is active. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/main/resources/application-swagger.properties`:
- Line 24: The jwt.secret property value contains a leading space; update the
property key jwt.secret so its value has no leading or trailing whitespace
(change " JWT_SECRET" to "JWT_SECRET") to ensure the secret is read correctly by
the application (verify trim or no surrounding quotes if any).
🧹 Nitpick comments (1)
.github/workflows/swagger-json.yml (1)
37-56: Consider adding an initial delay before polling.Spring Boot applications typically take 10-30 seconds to start. Adding an initial sleep before the polling loop could reduce unnecessary failed attempts and improve reliability.
Proposed improvement
- name: Wait for API & fetch Swagger run: | + echo "Waiting for Spring Boot to initialize..." + sleep 15 for i in {1..30}; do CODE=$(curl --connect-timeout 2 --max-time 5 -s -o swagger_raw.json -w "%{http_code}" http://localhost:9090/v3/api-docs || true)
|



Summary by CodeRabbit