Skip to content

test: add custom check options for strict internet access validation#117

Merged
OutdatedGuy merged 1 commit intomainfrom
fix/flaky-test
Dec 17, 2025
Merged

test: add custom check options for strict internet access validation#117
OutdatedGuy merged 1 commit intomainfrom
fix/flaky-test

Conversation

@OutdatedGuy
Copy link
Owner

No description provided.

Copy link
Owner Author

@OutdatedGuy OutdatedGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the test coverage for the enableStrictCheck feature by explicitly configuring custom check options. The change makes the test more explicit about using custom-defined URIs with strict checking, which aligns with the documented recommendation that enableStrictCheck should be used with custom URIs rather than defaults (to avoid reliability issues with external services).

Key Changes:

  • Added explicit customCheckOptions with 3 well-known URIs to the strict check test
  • Added useDefaultOptions: false to ensure only custom URIs are used
  • This makes the test more focused and follows the documented best practice for using enableStrictCheck

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@OutdatedGuy OutdatedGuy merged commit d10f57b into main Dec 17, 2025
9 checks passed
@OutdatedGuy OutdatedGuy deleted the fix/flaky-test branch December 17, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants