Skip to content

Conversation

@OS-pedrogustavobilro
Copy link
Contributor

Description

⚠️ AI-assisted PR with claude code, reviewed and validated by me.

Current SPM support lacks bundling the library's resources: flash on / flash off icons. This was causing a UI bug in iOS apps with SPM where the icons to be missing when opening the barcode scan screen.

This PR adds missing resources to Package.swift and corrects the SwiftUI code to retrieve the resource bundle properly.

Context

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality to not work as expected)

Tests

Pointed the capacitor example spm app to this branch, now the torch icons appear.

Also tested that CocoaPods still works by building the xcframework from this branch and replacing it the app.

So we don't have to download simulators
OS-pedrogustavobilro added a commit to OutSystems/cordova-outsystems-barcode that referenced this pull request Feb 5, 2026
OS-pedrogustavobilro added a commit that referenced this pull request Feb 5, 2026
@OS-pedrogustavobilro OS-pedrogustavobilro merged commit 4a3d137 into main Feb 5, 2026
6 of 7 checks passed
@OS-pedrogustavobilro OS-pedrogustavobilro deleted the RMET-4952 branch February 5, 2026 17:33
capacitor-bot pushed a commit that referenced this pull request Feb 6, 2026
## [2.1.1](2.1.0...2.1.1) (2026-02-06)

### Bug Fixes

* **ios:** bundle resources into Swift Package  ([#39](#39)) ([4a3d137](4a3d137))
capacitor-bot pushed a commit that referenced this pull request Feb 6, 2026
## [2.1.1](2.1.0...2.1.1) (2026-02-06)

### Bug Fixes

* **ios:** bundle resources into Swift Package  ([#39](#39)) ([4a3d137](4a3d137))
OS-pedrogustavobilro added a commit to ionic-team/capacitor-barcode-scanner that referenced this pull request Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants