Skip to content

Deploy 179: Upgrade OUSD Morpho V2 strategy implementation#2829

Open
sparrowDom wants to merge 2 commits intomasterfrom
sparrowDom/deploy_179
Open

Deploy 179: Upgrade OUSD Morpho V2 strategy implementation#2829
sparrowDom wants to merge 2 commits intomasterfrom
sparrowDom/deploy_179

Conversation

@sparrowDom
Copy link
Member

Deploy 179

  • Replaces the Generalized4626Strategy as the Morpho OUSD V2 strategy to MorphoV2Strategy which has better control over withdrawAll
  • sets the multichain strategist as the harvester

Deployed contracts:

Deployed contracts

contract name contract address
MorphoV2Strategy 0x34E28A257dF02fb3cEA12f0836fb8730B77ef9Cd

Proposal Id: 38234265178409078333598297388552567945868201345097914935151040432111128029390

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.60%. Comparing base (6b88f3d) to head (30ebde1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2829      +/-   ##
==========================================
+ Coverage   41.35%   43.60%   +2.25%     
==========================================
  Files         108      108              
  Lines        4607     4607              
  Branches     1254     1254              
==========================================
+ Hits         1905     2009     +104     
+ Misses       2699     2595     -104     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@naddison36
Copy link
Collaborator

  • All deployed contracts are listed in the deploy PR's description
  • Deployed contract's verified code (and all dependencies) match the code in master
  • Contract constructors have correct arguments
  • The transactions that interacted with the newly deployed contract match the deploy script.
  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal
sol2uml diff 0x34E28A257dF02fb3cEA12f0836fb8730B77ef9Cd .,node_modules
Compared the "MorphoV2Strategy" contract with address 0x34E28A257dF02fb3cEA12f0836fb8730B77ef9Cd on ethereum
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol
match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   @openzeppelin/contracts/utils/math/Math.sol
match   @openzeppelin/contracts/utils/math/SafeCast.sol
match   contracts/governance/Governable.sol
match   contracts/interfaces/IBasicToken.sol
match   contracts/interfaces/IMerkl.sol
match   contracts/interfaces/IStrategy.sol
match   contracts/interfaces/IVault.sol
match   contracts/interfaces/morpho/IMorphoV2Adapter.sol
match   contracts/interfaces/morpho/IVaultV2.sol
match   contracts/strategies/Generalized4626Strategy.sol
match   contracts/strategies/MorphoV2Strategy.sol
match   contracts/strategies/MorphoV2VaultUtils.sol
match   contracts/token/OUSD.sol
match   contracts/utils/Helpers.sol
match   contracts/utils/Initializable.sol
match   contracts/utils/InitializableAbstractStrategy.sol
match   contracts/vault/VaultStorage.sol
match   lib/openzeppelin/interfaces/IERC4626.sol

Copy link
Collaborator

@naddison36 naddison36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified the deployment

Copy link
Collaborator

@shahthepro shahthepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared the "MorphoV2Strategy" contract with address 0x34E28A257dF02fb3cEA12f0836fb8730B77ef9Cd on mainnet
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol
match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   @openzeppelin/contracts/utils/math/Math.sol
match   @openzeppelin/contracts/utils/math/SafeCast.sol
match   contracts/governance/Governable.sol
match   contracts/interfaces/IBasicToken.sol
match   contracts/interfaces/IMerkl.sol
match   contracts/interfaces/IStrategy.sol
match   contracts/interfaces/IVault.sol
match   contracts/interfaces/morpho/IMorphoV2Adapter.sol
match   contracts/interfaces/morpho/IVaultV2.sol
match   contracts/strategies/Generalized4626Strategy.sol
match   contracts/strategies/MorphoV2Strategy.sol
match   contracts/strategies/MorphoV2VaultUtils.sol
match   contracts/token/OUSD.sol
match   contracts/utils/Helpers.sol
match   contracts/utils/Initializable.sol
match   contracts/utils/InitializableAbstractStrategy.sol
match   contracts/vault/VaultStorage.sol
match   lib/openzeppelin/interfaces/IERC4626.sol

Copy link
Collaborator

@shahthepro shahthepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All deployed contracts are listed in the deploy PR's description
  • Deployed contract's verified code (and all dependencies) match the code in master
  • Contract constructors have correct arguments
  • The transactions that interacted with the newly deployed contract match the deploy script.
  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants