fix(ci,release scripts): fix ot3 tagging #20507
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## edge #20507 +/- ##
==========================================
+ Coverage 56.03% 56.31% +0.27%
==========================================
Files 3679 3633 -46
Lines 310579 306839 -3740
Branches 45838 45951 +113
==========================================
- Hits 174048 172804 -1244
+ Misses 136288 133790 -2498
- Partials 243 245 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix numeric tag sorting in internal-release.py
Tags like internal@v9, internal@v10, internal@v23 were being sorted alphabetically, causing v9 to appear as the latest (since '9' > '2' in ASCII). This fix extracts the numeric version and sorts by that instead, correctly identifying internal@v23 as the latest tag.