Skip to content

Conversation

@mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Jan 7, 2026

Closes AUTH-2561

Overview

This PR refactors the UX flow for creating and viewing existing QT protocol runs. The QT Dashboard is removed. Instead, existing QT protocols are accessible from the protocols view. A new button serves as the CTA for creating a new quick transfer. Existing flow behavior is preserved.

Screenshot 2026-01-07 at 1 55 49 PM

Test Plan and Hands on Testing

  • Smoke-tested a few quick transfer runs, ensuring that routing to the protocol dashboard occurs and existing in-flow QT behavior is preserved.

Changelog

  • Migrated Quick transfer run creation to the protocols tab on the ODD.
  • Removed filter criteria blocking quick transfer runs from appearing alongside historical protocol runs.
  • Removed the Quick Transfer tab on the ODD navbar.

Risk assessment

med-high: these changes touch quick transfer fundamentally and may result in a broken flow or unexpected routing path.

@mjhuff mjhuff added the DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available label Jan 7, 2026
@mjhuff
Copy link
Contributor Author

mjhuff commented Jan 7, 2026

We'd like to avoid merging these changes until the chore_release-9.0.0 branch is cut.

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes make sense to me

@mjhuff mjhuff force-pushed the app_quick-transfer-ui-refactor branch 2 times, most recently from 104078b to 0d1af53 Compare January 8, 2026 16:05
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 2.43902% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.11%. Comparing base (f31d91c) to head (0d1af53).
⚠️ Report is 11 commits behind head on edge.

Files with missing lines Patch % Lines
app/src/pages/ODD/ProtocolDashboard/index.tsx 0.00% 33 Missing ⚠️
...ransferDetails/DeleteTransferConfirmationModal.tsx 0.00% 2 Missing ⚠️
app/src/pages/ODD/RunSummary/index.tsx 0.00% 2 Missing ⚠️
...nisms/ODD/QuickTransferFlow/SummaryAndSettings.tsx 0.00% 1 Missing ⚠️
app/src/organisms/ODD/QuickTransferFlow/index.tsx 0.00% 1 Missing ⚠️
app/src/pages/ODD/QuickTransferDetails/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #20493      +/-   ##
==========================================
+ Coverage   56.10%   56.11%   +0.01%     
==========================================
  Files        3679     3681       +2     
  Lines      310284   310689     +405     
  Branches    45815    45852      +37     
==========================================
+ Hits       174088   174347     +259     
- Misses     135953   136096     +143     
- Partials      243      246       +3     
Flag Coverage Δ
app 46.29% <2.43%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/src/App/OnDeviceDisplayApp.tsx 79.14% <ø> (-0.27%) ⬇️
app/src/organisms/ODD/Navigation/index.tsx 94.00% <ø> (-0.12%) ⬇️
...DD/RunningProtocol/ConfirmCancelRunModal/index.tsx 78.00% <100.00%> (-1.05%) ⬇️
...ProtocolDashboard/PipetteNotAttachedErrorModal.tsx 6.06% <ø> (ø)
app/src/pages/ODD/ProtocolSetup/index.tsx 63.45% <ø> (-0.02%) ⬇️
app/src/pages/ODD/RunningProtocol/index.tsx 58.75% <ø> (+0.06%) ⬆️
app/src/redux/analytics/constants.ts 81.87% <ø> (-0.13%) ⬇️
...nisms/ODD/QuickTransferFlow/SummaryAndSettings.tsx 56.36% <0.00%> (ø)
app/src/organisms/ODD/QuickTransferFlow/index.tsx 2.94% <0.00%> (ø)
app/src/pages/ODD/QuickTransferDetails/index.tsx 80.25% <0.00%> (ø)
... and 3 more

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. i like this change in design a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants