Skip to content

Chore: Remove type checking blocks. #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hmgaudecker merged 10 commits into from
Feb 11, 2026
Merged

Chore: Remove type checking blocks. #72

hmgaudecker merged 10 commits into from
Feb 11, 2026

Conversation

@hmgaudecker
Copy link
Member

@hmgaudecker hmgaudecker commented Feb 10, 2026 •
edited
Loading

Remove if TYPE_CHECKING: blocks. They are just a distraction and will become pretty useless once we'll only support Python 3.14+

@review-notebook-app
Copy link

review-notebook-app bot commented Feb 10, 2026

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@codecov
Copy link

codecov bot commented Feb 10, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.53%. Comparing base (87954b3) to head (8c7698f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   95.40%   95.53%   +0.13%     
==========================================
  Files          23       25       +2     
  Lines        1153     1187      +34     
==========================================
+ Hits         1100     1134      +34     
  Misses         53       53

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dependabot bot and others added 4 commits February 10, 2026 09:28
@dependabot @hmgaudecker
Bump prefix-dev/setup-pixi in the github-actions group (#69)
f040261 
Bumps the github-actions group with 1 update: [prefix-dev/setup-pixi](https://github.com/prefix-dev/setup-pixi).


Updates `prefix-dev/setup-pixi` from 0.9.3 to 0.9.4
- [Release notes](https://github.com/prefix-dev/setup-pixi/releases)
- [Commits](prefix-dev/setup-pixi@v0.9.3...v0.9.4)

---
updated-dependencies:
- dependency-name: prefix-dev/setup-pixi
  dependency-version: 0.9.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Hans-Martin von Gaudecker <hmgaudecker@gmail.com>
@hmgaudecker
Remove 'if TYPE_CHECKING' blocks. Just distracting and they will beco…
a49e8b2 
…me pretty useless once we'll only support Python 3.14+
@hmgaudecker
Changes.
0771ad4
@hmgaudecker
Merge branch 'allow-sequence-in-with_signature' into chore-boilerplat…
95b1ed3 
…e-update
@hmgaudecker hmgaudecker changed the title Use pyproject-fmt instead of tox-toml-fmt, add nbstripout. Chore: Improved pre-commit hooks, remove type checking blocks. Feb 10, 2026
@hmgaudecker hmgaudecker requested a review from timmens February 10, 2026 09:29
timmens
timmens reviewed Feb 11, 2026
View reviewed changes
Copy link
Member

@timmens timmens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Looks much more readable without the TYPE_CHECKING block.

The PR title says "Improved pre-commit hooks", but I can't see any changes to the pre-commit hooks. Am I missing something?

@hmgaudecker
Copy link
Member Author

hmgaudecker commented Feb 11, 2026

The PR title says "Improved pre-commit hooks", but I can't see any changes to the pre-commit hooks. Am I missing something?

Apologies, I messed staggered PRs up yet again and this ended up in #71...

@hmgaudecker hmgaudecker changed the title Chore: Improved pre-commit hooks, remove type checking blocks. Chore: Remove type checking blocks. Feb 11, 2026
timmens
timmens approved these changes Feb 11, 2026
View reviewed changes
Copy link
Member

@timmens timmens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, perfect! Then this looks great to me! 🙂

Base automatically changed from typing-allow-sequence-instead-of-list-only to main February 11, 2026 09:39
@hmgaudecker hmgaudecker merged commit 1eb4af0 into main Feb 11, 2026
20 of 21 checks passed
@hmgaudecker hmgaudecker deleted the chore-boilerplate-update branch February 11, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timmens timmens timmens approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hmgaudecker @timmens