fix(sdk): restore ACP cost tracking fallback#2449
Open
LarytheLord wants to merge 1 commit intoOpenHands:mainfrom
Open
fix(sdk): restore ACP cost tracking fallback#2449LarytheLord wants to merge 1 commit intoOpenHands:mainfrom
LarytheLord wants to merge 1 commit intoOpenHands:mainfrom
Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PromptResponse.usagewhenUsageUpdate.costis missingUsageUpdate.costvalues against the estimated baseline instead of double-countingUsageUpdateand cover the new paths with ACP telemetry testsTesting
uv run pytest tests/sdk/agent/test_acp_agent.pyuv run pre-commit run --files openhands-sdk/openhands/sdk/agent/acp_agent.py tests/sdk/agent/test_acp_agent.pyFixes #2375.