fix(sdk): preserve model_name in get_combined_metrics#2446
Open
softpudding wants to merge 2 commits intoOpenHands:mainfrom
Open
fix(sdk): preserve model_name in get_combined_metrics#2446softpudding wants to merge 2 commits intoOpenHands:mainfrom
softpudding wants to merge 2 commits intoOpenHands:mainfrom
Conversation
The get_combined_metrics() method was creating a new Metrics() with the default model_name='default', losing the actual model name from tracked metrics. This fix extracts the model_name from the first metrics entry before creating the combined metrics. Co-authored-by: openhands <openhands@all-hands.dev>
malhotra5
reviewed
Mar 15, 2026
Comment on lines
+59
to
+64
| model_name = ( | ||
| next(iter(self.usage_to_metrics.values())).model_name | ||
| if self.usage_to_metrics | ||
| else "default" | ||
| ) | ||
| total_metrics = Metrics(model_name=model_name) |
Collaborator
There was a problem hiding this comment.
Hmm how would this work in the event we had multiple models with different names? Should we concatenate all the unique model names 😂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get_combined_metrics() method was creating a new Metrics() with the default model_name='default', losing the actual model name from tracked metrics. This fix extracts the model_name from the first metrics entry before creating the combined metrics.
Summary
[fill in a summary of this PR]
Checklist