Open
Conversation
Contributor
API breakage checks (Griffe)Result: Passed |
Contributor
Agent server REST API breakage checks (OpenAPI)Result: Failed Log excerpt (first 1000 characters) |
Contributor
Coverage Report •
|
||||||||||||||||||||
all-hands-bot
approved these changes
Mar 12, 2026
Collaborator
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Clean, pragmatic solution solving a real performance problem. No over-engineering, just straightforward implementation: optional parameter, conditional build skip, proper cleanup. Backward compatible, well-tested. This is how code should be written. LGTM! 🚀
This was referenced Mar 13, 2026
Co-authored-by: openhands <openhands@all-hands.dev>
e1753d6 to
ed53ab2
Compare
Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cache-toexport by default while keeping sharedcache-fromOPENHANDS_BUILDKIT_CACHE_MODE=off|min|maxso callers can disable or reducecache-toexportsScope
The prebuilt SDK sdist feature from this branch already merged separately in #2426, so this PR now carries only the remaining BuildKit cache export controls.
Behavior change
OPENHANDS_SHARED_REGISTRY_CACHE_EXPORT=1OPENHANDS_BUILDKIT_CACHE_MODE=max|min|offcontrols allcache-toexportsmaxkeeps full cache export behaviorminexports a smaller cacheoffdisables allcache-toexports while preservingcache-fromValidation
uv run pytest tests/agent_server/test_docker_build.pyuv run pre-commit run --files openhands-agent-server/openhands/agent_server/docker/build.py tests/agent_server/test_docker_build.pyAgent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.13-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:9c0379f-pythonRun
All tags pushed for this build
About Multi-Architecture Support
9c0379f-python) is a multi-arch manifest supporting both amd64 and arm649c0379f-python-amd64) are also available if needed